From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v5 02/12] blk-mq: fix direct issue
Date: Wed, 7 Jun 2017 10:50:29 +0800 [thread overview]
Message-ID: <20170607025028.GA5582@ming.t460p> (raw)
In-Reply-To: <1496764970.2692.7.camel@sandisk.com>
On Tue, Jun 06, 2017 at 04:02:52PM +0000, Bart Van Assche wrote:
> On Tue, 2017-06-06 at 23:22 +0800, Ming Lei wrote:
> > If queue is stopped, we shouldn't dispatch request into driver and
> > hardware, unfortunately the check is removed in bd166ef183c2(blk-mq-sched:
> > add framework for MQ capable IO schedulers).
> >
> > This patch fixes the issue by moving the check back into
> > __blk_mq_try_issue_directly().
> >
> > This patch fixes request use-after-free[1][2] during canceling requets
> > of NVMe in nvme_dev_disable(), which can be triggered easily during
> > NVMe reset & remove test.
>
> Although I'm not convinced that this patch fixes [2], the patch itself looks
The .q_usage_counter will be leaked once request is double free.
Thanks,
Ming
next prev parent reply other threads:[~2017-06-07 2:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 15:21 [PATCH v5 00/12] blk-mq: fix & improve queue quiescing Ming Lei
2017-06-06 15:21 ` [PATCH v5 01/12] blk-mq: pass correct hctx to blk_mq_try_issue_directly Ming Lei
2017-06-06 15:59 ` Bart Van Assche
2017-06-06 15:22 ` [PATCH v5 02/12] blk-mq: fix direct issue Ming Lei
2017-06-06 16:02 ` Bart Van Assche
2017-06-07 2:50 ` Ming Lei [this message]
2017-06-06 15:22 ` [PATCH v5 03/12] blk-mq: move blk_mq_quiesce_queue() into include/linux/blk-mq.h Ming Lei
2017-06-06 16:06 ` Bart Van Assche
2017-06-06 15:22 ` [PATCH v5 04/12] blk-mq: introduce blk_mq_quiesce_queue_nowait() Ming Lei
2017-06-06 15:22 ` [PATCH v5 05/12] blk-mq: introduce blk_mq_unquiesce_queue Ming Lei
2017-06-06 15:22 ` [PATCH v5 06/12] blk-mq: use the introduced blk_mq_unquiesce_queue() Ming Lei
2017-06-06 15:22 ` [PATCH v5 07/12] nvme: host: unquiesce queue in nvme_kill_queues() Ming Lei
2017-06-06 15:22 ` [PATCH v5 08/12] blk-mq: use QUEUE_FLAG_QUIESCED to quiesce queue Ming Lei
2017-06-06 16:03 ` Bart Van Assche
2017-06-06 15:22 ` [PATCH v5 09/12] blk-mq: update comments on blk_mq_quiesce_queue() Ming Lei
2017-06-06 15:22 ` [PATCH v5 10/12] blk-mq: don't stop queue for quiescing Ming Lei
2017-06-06 15:22 ` [PATCH v5 11/12] blk-mq: clarify dispatch may not be drained/blocked by stopping queue Ming Lei
2017-06-06 16:07 ` Bart Van Assche
2017-06-06 15:22 ` [PATCH v5 12/12] Revert "blk-mq: don't use sync workqueue flushing from drivers" Ming Lei
2017-06-06 16:03 ` [PATCH v5 00/12] blk-mq: fix & improve queue quiescing Jens Axboe
2017-06-13 2:15 ` Ming Lei
2017-06-18 20:26 ` Jens Axboe
2017-06-18 23:05 ` Bart Van Assche
2017-06-18 23:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607025028.GA5582@ming.t460p \
--to=ming.lei@redhat.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox