From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
adilger@dilger.ca, hch@infradead.org, martin.petersen@oracle.com
Subject: Re: [PATCH 05/11] block: add helpers for setting/checking stream validity
Date: Wed, 14 Jun 2017 13:28:57 -0700 [thread overview]
Message-ID: <20170614202857.GC7022@infradead.org> (raw)
In-Reply-To: <1497467134-6323-6-git-send-email-axboe@kernel.dk>
> +static const unsigned int rwf_write_to_opf_flag[] = {
> + 0, REQ_WRITE_SHORT, REQ_WRITE_MEDIUM, REQ_WRITE_LONG, REQ_WRITE_EXTREME
> +};
> +
> +/*
> + * 'stream_flags' is one of RWF_WRITE_LIFE_* values
> + */
> +void bio_set_streamid(struct bio *bio, unsigned int rwf_flags)
> +{
> + if (WARN_ON_ONCE(rwf_flags >= ARRAY_SIZE(rwf_write_to_opf_flag)))
> + return;
> +
> + bio->bi_opf |= rwf_write_to_opf_flag[rwf_flags];
> +}
> +EXPORT_SYMBOL_GPL(bio_set_streamid);
I'd move the bio->bi_opf assignment outş for a call like:
bio->bi_opf |= bio_op_write_bucket(flags);
and preferably move the flags masking / shifting into the helper as
well.
> };
>
> +static inline bool blk_stream_valid(unsigned int opf)
> +{
> + return (opf & REQ_WRITE_LIFE_MASK) != 0;
> +}
Replace the stream name here with lifetime or similar as well?
next prev parent reply other threads:[~2017-06-14 20:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 19:05 [PATCHSET v3] Add support for write life time hints Jens Axboe
2017-06-14 19:05 ` [PATCH 01/11] block: add support for carrying stream information in a bio Jens Axboe
2017-06-14 20:37 ` Christoph Hellwig
2017-06-14 20:44 ` Jens Axboe
2017-06-14 19:05 ` [PATCH 02/11] blk-mq: expose stream write stats through debugfs Jens Axboe
2017-06-14 19:05 ` [PATCH 03/11] fs: add support for an inode to carry stream related data Jens Axboe
2017-06-14 20:25 ` Christoph Hellwig
2017-06-14 20:37 ` Jens Axboe
2017-06-14 19:05 ` [PATCH 04/11] fs: add support for allowing applications to pass in write life time hints Jens Axboe
2017-06-14 20:26 ` Christoph Hellwig
2017-06-14 20:37 ` Jens Axboe
2017-06-14 19:05 ` [PATCH 05/11] block: add helpers for setting/checking stream validity Jens Axboe
2017-06-14 20:28 ` Christoph Hellwig [this message]
2017-06-14 20:39 ` Jens Axboe
2017-06-14 19:05 ` [PATCH 06/11] fs: add O_DIRECT support for sending down bio stream information Jens Axboe
2017-06-14 19:05 ` [PATCH 07/11] fs: add support for buffered writeback to pass down " Jens Axboe
2017-06-14 19:05 ` [PATCH 08/11] ext4: add support for passing in stream information for buffered writes Jens Axboe
2017-06-14 19:05 ` [PATCH 09/11] xfs: " Jens Axboe
2017-06-14 19:05 ` [PATCH 10/11] btrfs: " Jens Axboe
2017-06-15 1:31 ` Chris Mason
2017-06-14 19:05 ` [PATCH 11/11] nvme: add support for streams and directives Jens Axboe
2017-06-14 20:32 ` Christoph Hellwig
2017-06-14 20:43 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614202857.GC7022@infradead.org \
--to=hch@infradead.org \
--cc=adilger@dilger.ca \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).