* [PATCH] blk-tag: not touch rq->internal_tag
@ 2017-06-16 8:06 Ming Lei
2017-06-16 8:24 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Ming Lei @ 2017-06-16 8:06 UTC (permalink / raw)
To: Jens Axboe, linux-block, Christoph Hellwig; +Cc: Bart Van Assche, Ming Lei
rq->internal_tag is introduced only for blk-mq, so
it isn't necessary to touch this variable in blk-tag.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-tag.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/blk-tag.c b/block/blk-tag.c
index 07cc329fa4b0..bae1decb6ec3 100644
--- a/block/blk-tag.c
+++ b/block/blk-tag.c
@@ -272,7 +272,6 @@ void blk_queue_end_tag(struct request_queue *q, struct request *rq)
list_del_init(&rq->queuelist);
rq->rq_flags &= ~RQF_QUEUED;
rq->tag = -1;
- rq->internal_tag = -1;
if (unlikely(bqt->tag_index[tag] == NULL))
printk(KERN_ERR "%s: tag %d is missing\n",
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-tag: not touch rq->internal_tag
2017-06-16 8:06 [PATCH] blk-tag: not touch rq->internal_tag Ming Lei
@ 2017-06-16 8:24 ` Christoph Hellwig
2017-06-16 12:22 ` Ming Lei
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2017-06-16 8:24 UTC (permalink / raw)
To: Ming Lei; +Cc: Jens Axboe, linux-block, Christoph Hellwig, Bart Van Assche
On Fri, Jun 16, 2017 at 04:06:55PM +0800, Ming Lei wrote:
> rq->internal_tag is introduced only for blk-mq, so
> it isn't necessary to touch this variable in blk-tag.
>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
It's not harmful either, is it?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-tag: not touch rq->internal_tag
2017-06-16 8:24 ` Christoph Hellwig
@ 2017-06-16 12:22 ` Ming Lei
0 siblings, 0 replies; 3+ messages in thread
From: Ming Lei @ 2017-06-16 12:22 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Jens Axboe, linux-block, Bart Van Assche
On Fri, Jun 16, 2017 at 01:24:09AM -0700, Christoph Hellwig wrote:
> On Fri, Jun 16, 2017 at 04:06:55PM +0800, Ming Lei wrote:
> > rq->internal_tag is introduced only for blk-mq, so
> > it isn't necessary to touch this variable in blk-tag.
> >
> > Signed-off-by: Ming Lei <ming.lei@redhat.com>
>
> It's not harmful either, is it?
Yes, it is not harmful, also not necessary.
Thanks,
Ming
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-16 12:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-16 8:06 [PATCH] blk-tag: not touch rq->internal_tag Ming Lei
2017-06-16 8:24 ` Christoph Hellwig
2017-06-16 12:22 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox