From: Dan Carpenter <dan.carpenter@oracle.com>
To: axboe@fb.com
Cc: linux-block@vger.kernel.org
Subject: [bug report] mtip32xx: convert internal command issue to block IO path
Date: Fri, 23 Jun 2017 12:05:06 +0300 [thread overview]
Message-ID: <20170623090506.GA7127@elgon.mountain> (raw)
Hello Jens Axboe,
The patch 3f5e6a35774c: "mtip32xx: convert internal command issue to
block IO path" from Apr 28, 2017, leads to the following static
checker warning:
drivers/block/mtip32xx/mtip32xx.c:1067 mtip_exec_internal_command()
warn: 'int_cmd->status' is unsigned
drivers/block/mtip32xx/mtip32xx.c
1065
1066 rv = int_cmd->status;
^^^^^^^^^^^^^^^
This is a new block error code.
1067 if (rv < 0) {
^^^^^^
So this doesn't make sense. This used to be rv <= 0.
1068 if (rv == -ERESTARTSYS) { /* interrupted */
1069 dev_err(&dd->pdev->dev,
1070 "Internal command [%02X] was interrupted after %u ms\n",
1071 fis->command,
1072 jiffies_to_msecs(jiffies - start));
1073 rv = -EINTR;
1074 goto exec_ic_exit;
1075 } else if (rv == 0) /* timeout */
^^^^^^^
This doesn't make sense either.
1076 dev_err(&dd->pdev->dev,
1077 "Internal command did not complete [%02X] within timeout of %lu ms\n",
1078 fis->command, timeout);
1079 else
1080 dev_err(&dd->pdev->dev,
1081 "Internal command [%02X] wait returned code [%d] after %lu ms - unhandled\n",
1082 fis->command, rv, timeout);
1083
1084 if (mtip_check_surprise_removal(dd->pdev) ||
1085 test_bit(MTIP_DDF_REMOVE_PENDING_BIT,
1086 &dd->dd_flag)) {
1087 dev_err(&dd->pdev->dev,
1088 "Internal command [%02X] wait returned due to SR\n",
1089 fis->command);
1090 rv = -ENXIO;
regards,
dan carpenter
next reply other threads:[~2017-06-23 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 9:05 Dan Carpenter [this message]
2017-06-23 15:18 ` [bug report] mtip32xx: convert internal command issue to block IO path Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623090506.GA7127@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox