Re: [PATCH blktests 2/2] block/011: Perform PCI reset while doing IO

Johannes Thumshirn
2017-06-27T06:49:39Z

On Mon, Jun 26, 2017 at 02:27:24PM -0700, Omar Sandoval wrote:
[...]
> > +
> > + while kill -0 $! 2>/dev/null; do
> > + echo 0 > "/sys/bus/pci/devices/${pdev}/enable"
> > + sleep .2
> > + echo 1 > "/sys/bus/pci/devices/${pdev}/enable"
>
> Test looks good, but one question: do you want another sleep .2 here?
> Like this, you immediately disable it after enabling it, but maybe
> that's what you want :)

Good catch. I'll fix it up.

--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nï¿½rnberg
GF: Felix Imendï¿½rffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nï¿½rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850