From: Johannes Thumshirn <jthumshirn@suse.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me, bvanassche@acm.org,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
vladimirk@mellanox.com
Subject: Re: [PATCH 1/1] blk-mq: map all HWQ also in hyperthreaded system
Date: Wed, 28 Jun 2017 15:07:02 +0200 [thread overview]
Message-ID: <20170628130702.GQ4185@linux-x5ow.site> (raw)
In-Reply-To: <1498653880-29223-1-git-send-email-maxg@mellanox.com>
On Wed, Jun 28, 2017 at 03:44:40PM +0300, Max Gurtovoy wrote:
> This patch performs sequential mapping between CPUs and queues.
> In case the system has more CPUs than HWQs then there are still
> CPUs to map to HWQs. In hyperthreaded system, map the unmapped CPUs
> and their siblings to the same HWQ.
> This actually fixes a bug that found unmapped HWQs in a system with
> 2 sockets, 18 cores per socket, 2 threads per core (total 72 CPUs)
> running NVMEoF (opens upto maximum of 64 HWQs).
>From a first look at it, it looks good.
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Felix Imend�rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N�rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-06-28 13:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 12:44 [PATCH 1/1] blk-mq: map all HWQ also in hyperthreaded system Max Gurtovoy
2017-06-28 13:07 ` Johannes Thumshirn [this message]
2017-06-28 14:15 ` Christoph Hellwig
2017-06-28 14:38 ` Sagi Grimberg
2017-06-28 14:55 ` Max Gurtovoy
2017-06-28 15:01 ` Sagi Grimberg
2017-06-28 17:11 ` Max Gurtovoy
2017-06-29 8:30 ` Johannes Thumshirn
2017-06-28 14:43 ` Guilherme G. Piccoli
2017-06-28 14:58 ` Sagi Grimberg
2017-06-28 15:09 ` Max Gurtovoy
2017-06-29 5:33 ` Sagi Grimberg
2017-06-29 14:31 ` Christoph Hellwig
2017-07-03 13:38 ` Johannes Thumshirn
2017-07-05 7:59 ` Johannes Thumshirn
2017-07-05 8:11 ` Max Gurtovoy
2017-07-05 8:15 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628130702.GQ4185@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=axboe@fb.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=vladimirk@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox