From: Ming Lei <ming.lei@redhat.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH v2 1/8] nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw queues
Date: Wed, 5 Jul 2017 15:34:24 +0800 [thread overview]
Message-ID: <20170705073423.GG11084@ming.t460p> (raw)
In-Reply-To: <c349a9f0-d4cb-e19a-acc9-2b7157f6ec21@grimberg.me>
On Wed, Jul 05, 2017 at 10:15:28AM +0300, Sagi Grimberg wrote:
>
> > As I commented yesterday, blk_mq_kick_requeue_list() isn't needed.
>
> I commented in the cover-letter, I am removing it a two steps to keep
> bisection. I'm only allowed to remove it in patch 5/8.
The kick requeue list shouldn't be added at the 1st step.
The thing is simple, we only need to kick request list where the queue
is restarted. Now quiesce and unquiesce do not touch STOP state, so
it may make people confused if you add the kick after unquiese.
--
Ming
next prev parent reply other threads:[~2017-07-05 7:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 6:53 [PATCH v2 0/8] correct quiescing in several block drivers Sagi Grimberg
2017-07-05 6:53 ` [PATCH v2 1/8] nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw queues Sagi Grimberg
2017-07-05 7:12 ` Ming Lei
2017-07-05 7:15 ` Sagi Grimberg
2017-07-05 7:34 ` Ming Lei [this message]
2017-07-05 6:53 ` [PATCH v2 2/8] nvme-fc: " Sagi Grimberg
2017-07-05 7:16 ` Ming Lei
2017-07-05 6:53 ` [PATCH v2 3/8] nvme-loop: " Sagi Grimberg
2017-07-05 7:14 ` Ming Lei
2017-07-05 6:53 ` [PATCH v2 4/8] nvme-pci: " Sagi Grimberg
2017-07-05 7:20 ` Ming Lei
2017-07-05 6:53 ` [PATCH v2 5/8] nvme: kick requeue list when requeueing a request instead of when starting the queues Sagi Grimberg
2017-07-05 7:22 ` Ming Lei
2017-07-05 6:53 ` [PATCH v2 6/8] nbd: quiesce request queues to make sure no submissions are inflight Sagi Grimberg
2017-07-05 6:53 ` [PATCH v2 7/8] mtip32xx: " Sagi Grimberg
2017-07-05 7:28 ` Ming Lei
2017-07-05 6:53 ` [PATCH v2 8/8] virtio_blk: quiesce/unquiesce live IO when entering PM states Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705073423.GG11084@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox