linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Meelis Roos <mroos@linux.ee>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-block@vger.kernel.org
Subject: Re: OOPS from cciss_ioctl in 4.12+git
Date: Wed, 5 Jul 2017 15:51:34 -0700	[thread overview]
Message-ID: <20170705225134.GA31786@infradead.org> (raw)
In-Reply-To: <alpine.LRH.2.20.1707051555130.20086@math.ut.ee>

Hi Meelis,

can you try the patch below?

Also we're trying to move people away from the cciss driver, can you
check if the hpsa SCSI driver works for you as well?

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 02a611993bb4..678af946be30 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1944,6 +1944,13 @@ static void cciss_get_serial_no(ctlr_info_t *h, int logvol,
 	return;
 }
 
+static void cciss_initialize_rq(struct request *rq)
+{
+	struct scsi_request *sreq = blk_mq_rq_to_pdu(rq);
+
+	scsi_req_init(sreq);
+}
+
 /*
  * cciss_add_disk sets up the block device queue for a logical drive
  */
@@ -1956,6 +1963,7 @@ static int cciss_add_disk(ctlr_info_t *h, struct gendisk *disk,
 
 	disk->queue->cmd_size = sizeof(struct scsi_request);
 	disk->queue->request_fn = do_cciss_request;
+	disk->queue->initialize_rq_fn = cciss_initialize_rq;
 	disk->queue->queue_lock = &h->lock;
 	queue_flag_set_unlocked(QUEUE_FLAG_SCSI_PASSTHROUGH, disk->queue);
 	if (blk_init_allocated_queue(disk->queue) < 0)

  reply	other threads:[~2017-07-05 22:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 12:58 OOPS from cciss_ioctl in 4.12+git Meelis Roos
2017-07-05 22:51 ` Christoph Hellwig [this message]
2017-07-06  9:55   ` Meelis Roos
2017-07-07 15:00     ` device support in hpasa, was: " Christoph Hellwig
2017-07-07 15:03       ` Jens Axboe
2017-07-07 15:42         ` Laurence Oberman
2017-07-07 18:08           ` device support in hpsa, " Christoph Hellwig
2017-07-07 18:20             ` Laurence Oberman
2017-07-10 14:08             ` Meelis Roos
2017-07-10 21:56               ` Don Brace
2017-07-07 16:05         ` device support in hpasa, " Hannes Reinecke
2017-07-07 19:15           ` Don Brace

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170705225134.GA31786@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).