From: Ming Lei <ming.lei@redhat.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Sagi Grimberg <sagi@grimberg.me>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/6] xen-blkfront: avoid to use start/stop queue
Date: Wed, 12 Jul 2017 11:12:13 +0800 [thread overview]
Message-ID: <20170712031212.GF13036@ming.t460p> (raw)
In-Reply-To: <20170711212444.ttmkvlxexuduzfcj@MacBook-Pro-de-Roger.local>
On Tue, Jul 11, 2017 at 11:24:44PM +0200, Roger Pau Monn� wrote:
> On Wed, Jul 12, 2017 at 02:20:58AM +0800, Ming Lei wrote:
> > This interfaces will be removed soon, so use quiesce and
> > unquiesce instead, which should be more safe.
> >
> > The only one usage will be removed in the following
> > congestion control patches.
>
> Would it be better to simply fix blk_mq_{start/stop}_stopped_hw_queues
> rather than introducing a new interface?
No, we do not want to expose start/stop state to drivers any more, which
has caused enough trouble already, so these APIs need to be removed, and
quiesce/unquiesce is preferred way for this purpose, as you can see
the work done by Sagi Grimberg:
http://marc.info/?t=149927415900006&r=1&w=2
Thanks,
Ming
next prev parent reply other threads:[~2017-07-12 3:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 18:20 [PATCH 0/6] blk-mq: introduce congestion control Ming Lei
2017-07-11 18:20 ` [PATCH 1/6] xen-blkfront: avoid to use start/stop queue Ming Lei
2017-07-11 18:41 ` Konrad Rzeszutek Wilk
2017-07-12 2:52 ` Ming Lei
2017-07-11 18:41 ` Bart Van Assche
2017-07-12 2:59 ` Ming Lei
2017-07-12 3:05 ` Ming Lei
2017-07-11 21:24 ` Roger Pau Monné
2017-07-12 3:12 ` Ming Lei [this message]
2017-07-11 18:20 ` [PATCH 2/6] SCSI: use blk_mq_run_hw_queues() in scsi_kick_queue() Ming Lei
2017-07-11 19:57 ` Bart Van Assche
2017-07-12 3:15 ` Ming Lei
2017-07-12 15:12 ` Bart Van Assche
2017-07-13 10:23 ` Ming Lei
2017-07-13 17:44 ` Bart Van Assche
2017-07-11 18:21 ` [PATCH 3/6] blk-mq: send the request to dispatch list if direct issue returns busy Ming Lei
2017-07-11 20:18 ` Bart Van Assche
2017-07-12 3:45 ` Ming Lei
2017-07-11 18:21 ` [PATCH 4/6] blk-mq: use EWMA to estimate congestion threshold Ming Lei
2017-07-11 18:25 ` Jens Axboe
2017-07-12 2:30 ` Ming Lei
2017-07-12 15:39 ` Bart Van Assche
2017-07-13 10:43 ` Ming Lei
2017-07-13 14:56 ` Bart Van Assche
2017-07-13 15:32 ` Ming Lei
2017-07-13 17:35 ` Bart Van Assche
2017-07-11 18:39 ` Jens Axboe
2017-07-12 3:20 ` Ming Lei
2017-07-11 21:02 ` Bart Van Assche
2017-07-12 3:43 ` Ming Lei
2017-07-11 18:21 ` [PATCH 5/6] blk-mq: introduce basic congestion control Ming Lei
2017-07-11 18:21 ` [PATCH 6/6] blk-mq: unexport APIs for start/stop queues Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712031212.GF13036@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hch@infradead.org \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=sagi@grimberg.me \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox