From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH 12/14] blk-mq: introduce pointers to dispatch lock & list
Date: Tue, 1 Aug 2017 00:51:09 +0800 [thread overview]
Message-ID: <20170731165111.11536-14-ming.lei@redhat.com> (raw)
In-Reply-To: <20170731165111.11536-1-ming.lei@redhat.com>
Prepare to support per-request-queue dispatch list,
so introduce dispatch lock and list for avoiding to
do runtime check.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-mq-debugfs.c | 10 +++++-----
block/blk-mq.c | 7 +++++--
block/blk-mq.h | 26 +++++++++++++-------------
include/linux/blk-mq.h | 3 +++
4 files changed, 26 insertions(+), 20 deletions(-)
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index c4f70b453c76..4f8cddb8505f 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -370,23 +370,23 @@ static void *hctx_dispatch_start(struct seq_file *m, loff_t *pos)
{
struct blk_mq_hw_ctx *hctx = m->private;
- spin_lock(&hctx->lock);
- return seq_list_start(&hctx->dispatch, *pos);
+ spin_lock(hctx->dispatch_lock);
+ return seq_list_start(hctx->dispatch_list, *pos);
}
static void *hctx_dispatch_next(struct seq_file *m, void *v, loff_t *pos)
{
struct blk_mq_hw_ctx *hctx = m->private;
- return seq_list_next(v, &hctx->dispatch, pos);
+ return seq_list_next(v, hctx->dispatch_list, pos);
}
static void hctx_dispatch_stop(struct seq_file *m, void *v)
- __releases(&hctx->lock)
+ __releases(hctx->dispatch_lock)
{
struct blk_mq_hw_ctx *hctx = m->private;
- spin_unlock(&hctx->lock);
+ spin_unlock(hctx->dispatch_lock);
}
static const struct seq_operations hctx_dispatch_seq_ops = {
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 785145f60c1d..9b8b3a740d18 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1925,8 +1925,11 @@ static void blk_mq_exit_hw_queues(struct request_queue *q,
static void blk_mq_init_dispatch(struct request_queue *q,
struct blk_mq_hw_ctx *hctx)
{
- spin_lock_init(&hctx->lock);
- INIT_LIST_HEAD(&hctx->dispatch);
+ hctx->dispatch_lock = &hctx->lock;
+ hctx->dispatch_list = &hctx->dispatch;
+
+ spin_lock_init(hctx->dispatch_lock);
+ INIT_LIST_HEAD(hctx->dispatch_list);
}
static int blk_mq_init_hctx(struct request_queue *q,
diff --git a/block/blk-mq.h b/block/blk-mq.h
index 2ed355881996..d9795cbba1bb 100644
--- a/block/blk-mq.h
+++ b/block/blk-mq.h
@@ -152,38 +152,38 @@ static inline void blk_mq_hctx_clear_busy(struct blk_mq_hw_ctx *hctx)
static inline bool blk_mq_has_dispatch_rqs(struct blk_mq_hw_ctx *hctx)
{
- return !list_empty_careful(&hctx->dispatch);
+ return !list_empty_careful(hctx->dispatch_list);
}
static inline void blk_mq_add_rq_to_dispatch(struct blk_mq_hw_ctx *hctx,
struct request *rq)
{
- spin_lock(&hctx->lock);
- list_add(&rq->queuelist, &hctx->dispatch);
- spin_unlock(&hctx->lock);
+ spin_lock(hctx->dispatch_lock);
+ list_add(&rq->queuelist, hctx->dispatch_list);
+ spin_unlock(hctx->dispatch_lock);
}
static inline void blk_mq_add_list_to_dispatch(struct blk_mq_hw_ctx *hctx,
struct list_head *list)
{
- spin_lock(&hctx->lock);
- list_splice_init(list, &hctx->dispatch);
- spin_unlock(&hctx->lock);
+ spin_lock(hctx->dispatch_lock);
+ list_splice_init(list, hctx->dispatch_list);
+ spin_unlock(hctx->dispatch_lock);
}
static inline void blk_mq_add_list_to_dispatch_tail(struct blk_mq_hw_ctx *hctx,
struct list_head *list)
{
- spin_lock(&hctx->lock);
- list_splice_tail_init(list, &hctx->dispatch);
- spin_unlock(&hctx->lock);
+ spin_lock(hctx->dispatch_lock);
+ list_splice_tail_init(list, hctx->dispatch_list);
+ spin_unlock(hctx->dispatch_lock);
}
static inline void blk_mq_take_list_from_dispatch(struct blk_mq_hw_ctx *hctx,
struct list_head *list)
{
- spin_lock(&hctx->lock);
- list_splice_init(&hctx->dispatch, list);
+ spin_lock(hctx->dispatch_lock);
+ list_splice_init(hctx->dispatch_list, list);
/*
* BUSY won't be cleared until all requests
@@ -191,7 +191,7 @@ static inline void blk_mq_take_list_from_dispatch(struct blk_mq_hw_ctx *hctx,
*/
if (!list_empty(list))
blk_mq_hctx_set_busy(hctx);
- spin_unlock(&hctx->lock);
+ spin_unlock(hctx->dispatch_lock);
}
#endif
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 14f2ad3af31f..016f16c48f72 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -22,6 +22,9 @@ struct blk_mq_hw_ctx {
unsigned long flags; /* BLK_MQ_F_* flags */
+ spinlock_t *dispatch_lock;
+ struct list_head *dispatch_list;
+
void *sched_data;
struct request_queue *queue;
struct blk_flush_queue *fq;
--
2.9.4
next prev parent reply other threads:[~2017-07-31 16:53 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 16:50 [PATCH 00/14] blk-mq-sched: fix SCSI-MQ performance regression Ming Lei
2017-07-31 16:50 ` Ming Lei
2017-07-31 16:50 ` [PATCH 01/14] blk-mq-sched: fix scheduler bad performance Ming Lei
2017-07-31 23:00 ` Bart Van Assche
2017-07-31 16:50 ` [PATCH 02/14] blk-mq: rename flush_busy_ctx_data as ctx_iter_data Ming Lei
2017-07-31 23:03 ` Bart Van Assche
2017-07-31 16:51 ` [PATCH 03/14] blk-mq: introduce blk_mq_dispatch_rq_from_ctxs() Ming Lei
2017-07-31 23:09 ` Bart Van Assche
2017-08-01 10:07 ` Ming Lei
2017-08-02 17:19 ` kbuild test robot
2017-07-31 16:51 ` [PATCH 04/14] blk-mq-sched: improve dispatching from sw queue Ming Lei
2017-07-31 23:34 ` Bart Van Assche
2017-08-01 10:17 ` Ming Lei
2017-08-01 10:50 ` Ming Lei
2017-08-01 15:11 ` Bart Van Assche
2017-08-02 3:31 ` Ming Lei
2017-08-03 1:35 ` Bart Van Assche
2017-08-03 3:13 ` Ming Lei
2017-08-03 17:33 ` Bart Van Assche
2017-08-05 8:40 ` hch
2017-08-05 13:40 ` Ming Lei
2017-07-31 16:51 ` [PATCH 05/14] blk-mq-sched: don't dequeue request until all in ->dispatch are flushed Ming Lei
2017-07-31 23:42 ` Bart Van Assche
2017-08-01 10:44 ` Ming Lei
2017-08-01 16:14 ` Bart Van Assche
2017-08-02 3:01 ` Ming Lei
2017-08-03 1:33 ` Bart Van Assche
2017-07-31 16:51 ` [PATCH 06/14] blk-mq-sched: introduce blk_mq_sched_queue_depth() Ming Lei
2017-07-31 16:51 ` [PATCH 07/14] blk-mq-sched: use q->queue_depth as hint for q->nr_requests Ming Lei
2017-07-31 16:51 ` [PATCH 08/14] blk-mq: introduce BLK_MQ_F_SHARED_DEPTH Ming Lei
2017-07-31 16:51 ` [PATCH 09/14] blk-mq-sched: cleanup blk_mq_sched_dispatch_requests() Ming Lei
2017-07-31 16:51 ` [PATCH 10/14] blk-mq-sched: introduce helpers for query, change busy state Ming Lei
2017-07-31 16:51 ` [PATCH 11/14] blk-mq: introduce helpers for operating ->dispatch list Ming Lei
2017-07-31 16:51 ` Ming Lei [this message]
2017-07-31 16:51 ` [PATCH 13/14] blk-mq: pass 'request_queue *' to several helpers of operating BUSY Ming Lei
2017-07-31 16:51 ` [PATCH 14/14] blk-mq-sched: improve IO scheduling on SCSI devcie Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731165111.11536-14-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox