From: Christoph Hellwig <hch@lst.de>
To: Milan Broz <gmazyland@gmail.com>
Cc: linux-block@vger.kernel.org, hch@lst.de, axboe@kernel.dk,
mpatocka@redhat.com, dm-devel@redhat.com,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [RFC PATCH] bio-integrity: Fix regression if profile verify_fn is NULL
Date: Wed, 2 Aug 2017 14:55:09 +0200 [thread overview]
Message-ID: <20170802125509.GA18977@lst.de> (raw)
In-Reply-To: <20170802122750.12216-1-gmazyland@gmail.com>
On Wed, Aug 02, 2017 at 02:27:50PM +0200, Milan Broz wrote:
> In dm-integrity target we register integrity profile that have
> both generate_fn and verify_fn callbacks set to NULL.
>
> This is used if dm-integrity is stacked under a dm-crypt device
> for authenticated encryption (integrity payload contains authentication
> tag and IV seed).
>
> In this case the verification is done through own crypto API
> processing inside dm-crypt; integrity profile is only holder
> of these data. (And memory is owned by dm-crypt as well.)
Maybe that's where the problem lies? You're abusing the integrity
payload for something that is not end to end data integrity at all
and then wonder why it breaks? Also the commit that introduced your
code had absolutely no review by Martin or any of the core block
folks.
The right fix is to revert the dm-crypt commit.
next prev parent reply other threads:[~2017-08-02 12:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 12:27 [RFC PATCH] bio-integrity: Fix regression if profile verify_fn is NULL Milan Broz
2017-08-02 12:55 ` Christoph Hellwig [this message]
2017-08-02 13:15 ` Milan Broz
2017-08-02 14:11 ` Martin K. Petersen
2017-08-02 15:24 ` Milan Broz
2017-08-03 14:10 ` [PATCH] bio-integrity: revert "stop abusing bi_end_io" Mikulas Patocka
2017-08-05 13:44 ` Christoph Hellwig
2017-08-05 14:46 ` Mikulas Patocka
2017-08-05 20:25 ` Martin K. Petersen
2017-08-06 18:49 ` Mikulas Patocka
2017-08-07 15:48 ` Martin K. Petersen
2017-08-08 6:47 ` Milan Broz
2017-08-05 20:19 ` Martin K. Petersen
2017-08-09 14:07 ` Christoph Hellwig
2017-08-06 13:30 ` [RFC PATCH] bio-integrity: Fix regression if profile verify_fn is NULL Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802125509.GA18977@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).