From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 5 Aug 2017 13:39:32 +0200 From: Christoph Hellwig To: Hannes Reinecke Cc: "Martin K. Petersen" , Christoph Hellwig , Johannes Thumshirn , Jens Axboe , linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, Hannes Reinecke Subject: Re: [PATCH 3/4] scsi: add Mylex RAID controller Message-ID: <20170805113932.GF16313@lst.de> References: <1501683208-5240-1-git-send-email-hare@suse.de> <1501683208-5240-4-git-send-email-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1501683208-5240-4-git-send-email-hare@suse.de> List-ID: Can you use normal linux style for the code instead of copy and pasting the weird naming and capitalization from the DAC960 driver? Also please use the driver name as prefix for the functions. Maybe myraid instead of mylex? I'll take a more detailed look at the actual driver in a bit.