Re: [PATCH V2 08/20] blk-mq-sched: use q->queue_depth as hint for q->nr_requests

Ming Lei
2017-08-24T06:39:51Z

On Tue, Aug 22, 2017 at 08:20:20PM +0000, Bart Van Assche wrote:
> On Sat, 2017-08-05 at 14:56 +0800, Ming Lei wrote:
> > SCSI sets q->queue_depth from shost->cmd_per_lun, and
> > q->queue_depth is per request_queue and more related to
> > scheduler queue compared with hw queue depth, which can be
> > shared by queues, such as TAG_SHARED.
> >
> > This patch trys to use q->queue_depth as hint for computing
> ^^^^
> tries?

Will fix it in V3.

> > q->nr_requests, which should be more effective than
> > current way.
>
> Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>

Thanks!

--
Ming