From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Tue, 8 Aug 2017 15:48:00 -0700 From: Omar Sandoval To: Jens Axboe Cc: linux-block@vger.kernel.org, brking@linux.vnet.ibm.com, bart.vanassche@wdc.com Subject: Re: [PATCH 5/6] blk-mq: enable checking two part inflight counts at the same time Message-ID: <20170808224800.GG4072@vader.DHCP.thefacebook.com> References: <1501859062-11120-1-git-send-email-axboe@kernel.dk> <1501859062-11120-6-git-send-email-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1501859062-11120-6-git-send-email-axboe@kernel.dk> List-ID: On Fri, Aug 04, 2017 at 09:04:21AM -0600, Jens Axboe wrote: > Modify blk_mq_in_flight() to count both a partition and root at > the same time. Then we only have to call it once, instead of > potentially looping the tags twice. Reviewed-by: Omar Sandoval One comment below. > Signed-off-by: Jens Axboe [snip] > diff --git a/block/blk-mq.c b/block/blk-mq.c > index fe1aa1f5f069..410ed246bc9b 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -98,11 +98,13 @@ static void blk_mq_check_inflight(struct blk_mq_hw_ctx *hctx, > return; > > /* > - * Count as inflight if it either matches the partition we asked > - * for, or if it's the root > + * Count as inflight if it matches the partition, count separately > + * (but all) if we got asked for the root > */ > - if (rq->part == mi->part || mi->part->partno) > + if (rq->part == mi->part) > mi->inflight[0]++; Similar concern as with patch 3, why special case the part0 case below? > + if (mi->part->partno) > + mi->inflight[1]++; > }