From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Johannes Thumshirn <jth@kernel.org>, Jens Axboe <axboe@kernel.dk>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 3/4] scsi: add Mylex RAID controller
Date: Wed, 9 Aug 2017 16:10:49 +0200 [thread overview]
Message-ID: <20170809141049.GB26843@lst.de> (raw)
In-Reply-To: <17589cb4-9f0c-7d15-8c3a-79bd9b14fdef@suse.de>
On Mon, Aug 07, 2017 at 08:09:11AM +0200, Hannes Reinecke wrote:
> On 08/05/2017 01:39 PM, Christoph Hellwig wrote:
> > Can you use normal linux style for the code instead of copy and
> > pasting the weird naming and capitalization from the DAC960 driver?
> >
> Yes; already planned for v2. But first wanted to get some general
> feedback (like: is anyone interested in that at all?)
Yes, please go ahead and kill off the DAC960 driver.
>
> > Also please use the driver name as prefix for the functions.
> >
> Ok.
>
> > Maybe myraid instead of mylex?
> >
> Nah; I'd rather stick with mylex.
> (Especially as it says 'Mylex' in big fat letters on the board :-)
Naming drivers after the vendor only is usually a bad idea as vendors
have/had multiple products. In this case we have plenty other drivers
that support Mylex products.
next prev parent reply other threads:[~2017-08-09 14:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 14:13 [PATCH 0/4] mylex: Replace DAC960 block driver Hannes Reinecke
2017-08-02 14:13 ` [PATCH 1/4] raid_class: Add 'JBOD' RAID level Hannes Reinecke
2017-08-02 14:13 ` [PATCH 2/4] scsi: Add VENDOR_SPECIFIC sense code definitions Hannes Reinecke
2017-08-02 14:13 ` [PATCH 3/4] scsi: add Mylex RAID controller Hannes Reinecke
2017-08-05 11:39 ` Christoph Hellwig
2017-08-07 6:09 ` Hannes Reinecke
2017-08-09 14:10 ` Christoph Hellwig [this message]
2017-08-09 15:11 ` Hannes Reinecke
2017-08-02 14:13 ` [PATCH 4/4] block: Drop obsolete DAC960 driver Hannes Reinecke
2017-08-09 14:23 ` [PATCH 0/4] mylex: Replace DAC960 block driver Christoph Hellwig
2017-08-09 15:09 ` Hannes Reinecke
2018-01-08 11:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809141049.GB26843@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=jth@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).