From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: mpatocka@redhat.com, gmazyland@gmail.com,
martin.petersen@oracle.com, linux-block@vger.kernel.org,
dm-devel@redhat.com
Subject: [PATCH 2/2] dm-crypt: don't mess with BIP_BLOCK_INTEGRITY
Date: Wed, 9 Aug 2017 17:48:09 +0200 [thread overview]
Message-ID: <20170809154809.2168-3-hch@lst.de> (raw)
In-Reply-To: <20170809154809.2168-1-hch@lst.de>
This flag is never set right after calling bio_integrity_alloc,
so don't clear it and confuse the reader.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/md/dm-crypt.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c
index cdf6b1e12460..73c2e270cda6 100644
--- a/drivers/md/dm-crypt.c
+++ b/drivers/md/dm-crypt.c
@@ -933,9 +933,6 @@ static int dm_crypt_integrity_io_alloc(struct dm_crypt_io *io, struct bio *bio)
bip->bip_iter.bi_size = tag_len;
bip->bip_iter.bi_sector = io->cc->start + io->sector;
- /* We own the metadata, do not let bio_free to release it */
- bip->bip_flags &= ~BIP_BLOCK_INTEGRITY;
-
ret = bio_integrity_add_page(bio, virt_to_page(io->integrity_metadata),
tag_len, offset_in_page(io->integrity_metadata));
if (unlikely(ret != tag_len))
--
2.11.0
next prev parent reply other threads:[~2017-08-09 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 15:48 two small integrity cleanups Christoph Hellwig
2017-08-09 15:48 ` [PATCH 1/2] bio-integrity: move the bio integrity profile check earlier in bio_integrity_prep Christoph Hellwig
2017-08-09 15:48 ` Christoph Hellwig [this message]
2017-08-09 16:00 ` two small integrity cleanups Jens Axboe
2017-08-09 16:22 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809154809.2168-3-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox