From: Christoph Hellwig <hch@lst.de>
To: Omar Sandoval <osandov@osandov.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-block@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] blk-mq-pci: add a fallback when pci_irq_get_affinity returns NULL
Date: Fri, 18 Aug 2017 13:24:13 +0200 [thread overview]
Message-ID: <20170818112413.GA7700@lst.de> (raw)
In-Reply-To: <20170817203742.GC2459@vader>
On Thu, Aug 17, 2017 at 01:37:42PM -0700, Omar Sandoval wrote:
> On Thu, Aug 17, 2017 at 12:24:47PM +0200, Christoph Hellwig wrote:
> > While pci_irq_get_affinity should never fail for SMP kernel that
> > implement the affinity mapping, it will always return NULL in the
> > UP case, so provide a fallback mapping of all queues to CPU 0 in
> > that case.
>
> Reviewed-by: Omar Sandoval <osandov@fb.com>
>
> Has nvme been fixed to not crash if blk_mq_alloc_tag_set() fails?
No - Sagi didn't like the little fix from Max and no one else
has followed up. I'll take a look.
next prev parent reply other threads:[~2017-08-18 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 10:24 [PATCH] blk-mq-pci: add a fallback when pci_irq_get_affinity returns NULL Christoph Hellwig
2017-08-17 20:37 ` Omar Sandoval
2017-08-18 11:24 ` Christoph Hellwig [this message]
2017-08-18 14:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818112413.GA7700@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).