public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Milan Broz <gmazyland@gmail.com>
Cc: linux-block@vger.kernel.org, kzak@redhat.com, axboe@kernel.dk,
	hare@suse.de
Subject: Re: [PATCH] loop: Fix freeze if configured block size is not supported
Date: Mon, 21 Aug 2017 11:47:52 -0700	[thread overview]
Message-ID: <20170821184752.GB16030@vader.DHCP.thefacebook.com> (raw)
In-Reply-To: <20170818130733.11254-1-gmazyland@gmail.com>

On Fri, Aug 18, 2017 at 03:07:33PM +0200, Milan Broz wrote:
> The commit f2c6df7dbf9a60e1cd9941f9fb376d4d9ad1e8dd
> 
>     loop: support 4k physical blocksize
> 
> adds support for loop block size with only specific block sizes.
> 
> If the size is not supported, the code returns -EINVAL keeping
> the loop queue frozen. This causes that device could be locked
> for a long time by processes trying to scan device (udev).
> (And also causing subsequent LOOP_CLR_FD operations noop.)
> 
> Fix it by using goto to proper exit location with queue unfreeze.
> 
> (The same bug is for setting crypt attribute but this code is
> probably no more used. Patch fixes it as well though.)
> 
> Signed-off-by: Milan Broz <gmazyland@gmail.com>

Heh, I sent the same patch [1] only hours before :) v2 is here [2] if
you want to give it a reviewed-by.

1: https://marc.info/?l=linux-block&m=150303694018659&w=2
2: https://marc.info/?l=linux-block&m=150308446732748&w=2

  reply	other threads:[~2017-08-21 18:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 13:07 [PATCH] loop: Fix freeze if configured block size is not supported Milan Broz
2017-08-21 18:47 ` Omar Sandoval [this message]
2017-08-21 19:11   ` Milan Broz
2017-08-21 19:19     ` Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170821184752.GB16030@vader.DHCP.thefacebook.com \
    --to=osandov@osandov.com \
    --cc=axboe@kernel.dk \
    --cc=gmazyland@gmail.com \
    --cc=hare@suse.de \
    --cc=kzak@redhat.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox