From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:55590 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111AbdHXGyN (ORCPT ); Thu, 24 Aug 2017 02:54:13 -0400 Date: Thu, 24 Aug 2017 14:54:00 +0800 From: Ming Lei To: Bart Van Assche Cc: "hch@infradead.org" , "linux-block@vger.kernel.org" , "axboe@fb.com" , "loberman@redhat.com" Subject: Re: [PATCH V2 10/20] blk-mq-sched: introduce helpers for query, change busy state Message-ID: <20170824065400.GK12966@ming.t460p> References: <20170805065705.12989-1-ming.lei@redhat.com> <20170805065705.12989-11-ming.lei@redhat.com> <1503434472.2508.19.camel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1503434472.2508.19.camel@wdc.com> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Tue, Aug 22, 2017 at 08:41:14PM +0000, Bart Van Assche wrote: > On Sat, 2017-08-05 at 14:56 +0800, Ming Lei wrote: > > +static inline bool blk_mq_hctx_is_dispatch_busy(struct blk_mq_hw_ctx *hctx) > > +{ > > + return test_bit(BLK_MQ_S_DISPATCH_BUSY, &hctx->state); > > +} > > + > > +static inline void blk_mq_hctx_set_dispatch_busy(struct blk_mq_hw_ctx *hctx) > > +{ > > + set_bit(BLK_MQ_S_DISPATCH_BUSY, &hctx->state); > > +} > > + > > +static inline void blk_mq_hctx_clear_dispatch_busy(struct blk_mq_hw_ctx *hctx) > > +{ > > + clear_bit(BLK_MQ_S_DISPATCH_BUSY, &hctx->state); > > +} > > Hello Ming, > > Are these helper functions modified in a later patch? If not, please drop > this patch. One line helper functions are not useful and do not improve > readability of source code. It is definitely modified in later patch, :-) -- Ming