Re: [PATCH V2 05/20] blk-mq-sched: improve dispatching from sw queue

Jens Axboe
2017-08-23T19:58:16Z

On Tue, Aug 22 2017, Bart Van Assche wrote:
> On Sat, 2017-08-05 at 14:56 +0800, Ming Lei wrote:
> > easy to cause queue busy becasue of the small
> ^^^^^^^
> because?
>
> > -static void blk_mq_do_dispatch(struct request_queue *q,
> > - struct elevator_queue *e,
> > - struct blk_mq_hw_ctx *hctx)
> > +static inline void blk_mq_do_dispatch_sched(struct request_queue *q,
> > + struct elevator_queue *e,
> > + struct blk_mq_hw_ctx *hctx)
> > {
> > LIST_HEAD(rq_list);
>
> Why to declare this function "inline"? Are you sure that the compiler
> is not smart enough to decide on its own whether or not to inline this
> function?

Ditto in other places, too. Kill them.

--
Jens Axboe