From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] block: Call .initialize_rq_fn() also for filesystem requests
Date: Mon, 28 Aug 2017 10:10:17 +0200 [thread overview]
Message-ID: <20170828081017.GC2851@lst.de> (raw)
In-Reply-To: <20170825190057.15592-1-bart.vanassche@wdc.com>
I still disagree that we should have an indirect function call like this
in the fast path.
All that can be done by clearing or setting a flag on the first call to
->queue_rq or ->queuecommand instead. In NVMe we use RQF_DONTPREP for
that, but for SCSI we probablt can't use that given that it has more
meaning for the old request path. But how about just adding a new
RQD_DRV_INITIALIZED or similar flag?
next prev parent reply other threads:[~2017-08-28 8:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 19:00 [PATCH] block: Call .initialize_rq_fn() also for filesystem requests Bart Van Assche
2017-08-28 8:10 ` Christoph Hellwig [this message]
2017-08-28 18:31 ` Bart Van Assche
2017-08-29 11:16 ` Ming Lei
2017-08-29 20:15 ` Bart Van Assche
2017-08-30 3:01 ` Ming Lei
2017-08-29 13:12 ` hch
2017-08-29 20:57 ` Bart Van Assche
2017-08-29 21:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828081017.GC2851@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).