From: Keith Busch <keith.busch@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 10/10] nvme: implement multipath access to nvme subsystems
Date: Tue, 29 Aug 2017 11:41:38 -0400 [thread overview]
Message-ID: <20170829154138.GB4428@localhost.localdomain> (raw)
In-Reply-To: <20170829145559.GA32760@lst.de>
On Tue, Aug 29, 2017 at 04:55:59PM +0200, Christoph Hellwig wrote:
> On Tue, Aug 29, 2017 at 10:54:17AM -0400, Keith Busch wrote:
> > It also looks like new submissions will get a new path only from the
> > fact that the original/primary is being reset. The controller reset
> > itself seems a bit heavy-handed. Can we just set head->current_path to
> > the next active controller in the list?
>
> For ANA we'll have to do that anyway, but if we got a failure
> that clearly indicates a path failure what benefit is there in not
> resetting the controller? But yeah, maybe we can just switch the
> path for non-ANA controllers and wait for timeouts to do their work.
Okay, sounds reasonable.
Speaking of timeouts, nvme_req_needs_retry will fail the command
immediately rather than try the alternate path if it was cancelled due
to timeout handling. Should we create a new construct for a command's
total time separate from recovery timeout so we may try an alternate
paths?
next prev parent reply other threads:[~2017-08-29 15:37 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 17:58 RFC: nvme multipath support Christoph Hellwig
2017-08-23 17:58 ` [PATCH 01/10] nvme: report more detailed status codes to the block layer Christoph Hellwig
2017-08-28 6:06 ` Sagi Grimberg
2017-08-28 18:50 ` Keith Busch
2017-08-23 17:58 ` [PATCH 02/10] nvme: allow calling nvme_change_ctrl_state from irq context Christoph Hellwig
2017-08-28 6:06 ` Sagi Grimberg
2017-08-28 18:50 ` Keith Busch
2017-08-23 17:58 ` [PATCH 03/10] nvme: remove unused struct nvme_ns fields Christoph Hellwig
2017-08-28 6:07 ` Sagi Grimberg
2017-08-28 19:13 ` Keith Busch
2017-08-23 17:58 ` [PATCH 04/10] nvme: remove nvme_revalidate_ns Christoph Hellwig
2017-08-28 6:12 ` Sagi Grimberg
2017-08-28 19:14 ` Keith Busch
2017-08-23 17:58 ` [PATCH 05/10] nvme: don't blindly overwrite identifiers on disk revalidate Christoph Hellwig
2017-08-28 6:17 ` Sagi Grimberg
2017-08-28 6:23 ` Christoph Hellwig
2017-08-28 6:32 ` Sagi Grimberg
2017-08-28 19:15 ` Keith Busch
2017-08-23 17:58 ` [PATCH 06/10] nvme: track subsystems Christoph Hellwig
2017-08-23 22:04 ` Keith Busch
2017-08-24 8:52 ` Christoph Hellwig
2017-08-28 6:22 ` Sagi Grimberg
2017-08-23 17:58 ` [PATCH 07/10] nvme: track shared namespaces Christoph Hellwig
2017-08-28 6:51 ` Sagi Grimberg
2017-08-28 8:50 ` Christoph Hellwig
2017-08-28 20:21 ` J Freyensee
2017-08-29 8:25 ` Christoph Hellwig
2017-08-29 6:54 ` Guan Junxiong
2017-08-28 12:04 ` javigon
2017-08-28 12:41 ` Guan Junxiong
2017-08-28 14:30 ` Christoph Hellwig
2017-08-29 2:42 ` Guan Junxiong
2017-08-29 8:30 ` Christoph Hellwig
2017-08-29 8:29 ` Christoph Hellwig
2017-08-28 19:18 ` Keith Busch
2017-08-23 17:58 ` [PATCH 08/10] block: provide a generic_make_request_fast helper Christoph Hellwig
2017-08-28 7:00 ` Sagi Grimberg
2017-08-28 8:54 ` Christoph Hellwig
2017-08-28 11:01 ` Sagi Grimberg
2017-08-28 11:54 ` Christoph Hellwig
2017-08-28 12:38 ` Sagi Grimberg
2017-08-23 17:58 ` [PATCH 09/10] blk-mq: add a blk_steal_bios helper Christoph Hellwig
2017-08-28 7:04 ` Sagi Grimberg
2017-08-23 17:58 ` [PATCH 10/10] nvme: implement multipath access to nvme subsystems Christoph Hellwig
2017-08-23 18:21 ` Bart Van Assche
2017-08-24 8:59 ` hch
2017-08-24 20:17 ` Bart Van Assche
2017-09-05 11:53 ` Christoph Hellwig
2017-09-11 6:34 ` Tony Yang
2017-08-23 22:53 ` Keith Busch
2017-08-24 8:52 ` Christoph Hellwig
2017-08-28 7:23 ` Sagi Grimberg
2017-08-28 9:06 ` Christoph Hellwig
2017-08-28 13:40 ` Sagi Grimberg
2017-08-28 14:24 ` Christoph Hellwig
2017-09-07 15:17 ` Tony Yang
2017-08-29 10:22 ` Guan Junxiong
2017-08-29 14:51 ` Christoph Hellwig
2017-08-29 14:54 ` Keith Busch
2017-08-29 14:55 ` Christoph Hellwig
2017-08-29 15:41 ` Keith Busch [this message]
2017-09-18 0:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829154138.GB4428@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).