Linux block layer
 help / color / mirror / Atom feed
From: Scott Bauer <scott.bauer@intel.com>
To: Jon Derrick <jonathan.derrick@intel.com>
Cc: linux-block@vger.kernel.org, david.fugate@intel.com,
	axboe@fb.com, hch@infradead.org, rafael.antognolli@intel.com
Subject: Re: [PATCH] block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled
Date: Thu, 31 Aug 2017 13:58:01 -0600	[thread overview]
Message-ID: <20170831195759.nsnwys2lvgrxbvg4@sbauer-Z170X-UD5> (raw)
In-Reply-To: <f8da2845-bc33-8afb-2695-958b0a7425f1@intel.com>

On Thu, Aug 31, 2017 at 02:10:36PM -0600, Jon Derrick wrote:
> Hey Scott,
> > +static int __opal_set_mbr_done(struct opal_dev *dev, struct opal_key *key)
> > +{
> > +	u8 mbr_done_tf = 1;
> > +	const struct opal_step mbrdone_step [] = {
> > +		{ opal_discovery0, },
> > +		{ start_admin1LSP_opal_session, key },
> > +		{ set_mbr_done, &mbr_done_tf },
> Do you need to end_opal_session here?
>
Yep, sure do. I'll wait for Christoph to look at it tonight before spinning another.
> > +		{ NULL, }
> > +	};
> > +

  reply	other threads:[~2017-08-31 20:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31 17:42 [PATCH] block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled Scott Bauer
2017-08-31 20:10 ` Jon Derrick
2017-08-31 19:58   ` Scott Bauer [this message]
2017-09-01  7:31     ` Christoph Hellwig
2017-08-31 20:19 ` Jens Axboe
2017-08-31 20:13   ` Scott Bauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170831195759.nsnwys2lvgrxbvg4@sbauer-Z170X-UD5 \
    --to=scott.bauer@intel.com \
    --cc=axboe@fb.com \
    --cc=david.fugate@intel.com \
    --cc=hch@infradead.org \
    --cc=jonathan.derrick@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=rafael.antognolli@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox