linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@fb.com>,
	linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>,
	Laurence Oberman <loberman@redhat.com>,
	Paolo Valente <paolo.valente@linaro.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V4 10/14] block: move actual bio merge code into __elv_merge
Date: Sat,  2 Sep 2017 23:17:25 +0800	[thread overview]
Message-ID: <20170902151729.6162-11-ming.lei@redhat.com> (raw)
In-Reply-To: <20170902151729.6162-1-ming.lei@redhat.com>

So that we can reuse __elv_merge() to merge bio
into requests from sw queue in the following patches.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 block/elevator.c | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/block/elevator.c b/block/elevator.c
index 824cc3e69ac3..e11c7873fc21 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -409,8 +409,9 @@ void elv_dispatch_add_tail(struct request_queue *q, struct request *rq)
 }
 EXPORT_SYMBOL(elv_dispatch_add_tail);
 
-enum elv_merge elv_merge(struct request_queue *q, struct request **req,
-		struct bio *bio)
+static enum elv_merge __elv_merge(struct request_queue *q,
+		struct request **req, struct bio *bio,
+		struct hlist_head *hash, struct request *last_merge)
 {
 	struct elevator_queue *e = q->elevator;
 	struct request *__rq;
@@ -427,11 +428,11 @@ enum elv_merge elv_merge(struct request_queue *q, struct request **req,
 	/*
 	 * First try one-hit cache.
 	 */
-	if (q->last_merge && elv_bio_merge_ok(q->last_merge, bio)) {
-		enum elv_merge ret = blk_try_merge(q->last_merge, bio);
+	if (last_merge && elv_bio_merge_ok(last_merge, bio)) {
+		enum elv_merge ret = blk_try_merge(last_merge, bio);
 
 		if (ret != ELEVATOR_NO_MERGE) {
-			*req = q->last_merge;
+			*req = last_merge;
 			return ret;
 		}
 	}
@@ -442,7 +443,7 @@ enum elv_merge elv_merge(struct request_queue *q, struct request **req,
 	/*
 	 * See if our hash lookup can find a potential backmerge.
 	 */
-	__rq = elv_rqhash_find(q, bio->bi_iter.bi_sector);
+	__rq = rqhash_find(hash, bio->bi_iter.bi_sector);
 	if (__rq && elv_bio_merge_ok(__rq, bio)) {
 		*req = __rq;
 		return ELEVATOR_BACK_MERGE;
@@ -456,6 +457,12 @@ enum elv_merge elv_merge(struct request_queue *q, struct request **req,
 	return ELEVATOR_NO_MERGE;
 }
 
+enum elv_merge elv_merge(struct request_queue *q, struct request **req,
+		struct bio *bio)
+{
+	return __elv_merge(q, req, bio, q->elevator->hash, q->last_merge);
+}
+
 /*
  * Attempt to do an insertion back merge. Only check for the case where
  * we can append 'rq' to an existing request, so we can throw 'rq' away
-- 
2.9.5

  parent reply	other threads:[~2017-09-02 15:19 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-02 15:17 [PATCH V4 00/14] blk-mq-sched: improve SCSI-MQ performance Ming Lei
2017-09-02 15:17 ` [PATCH V4 01/14] blk-mq-sched: fix scheduler bad performance Ming Lei
2017-09-08 20:48   ` Omar Sandoval
2017-09-08 20:54     ` Omar Sandoval
2017-09-08 20:56       ` Omar Sandoval
2017-09-09  7:43         ` Ming Lei
2017-09-09  7:33       ` Ming Lei
2017-09-02 15:17 ` [PATCH V4 02/14] sbitmap: introduce __sbitmap_for_each_set() Ming Lei
2017-09-08 20:43   ` Omar Sandoval
2017-09-09  9:38     ` Ming Lei
2017-09-10 17:20       ` Omar Sandoval
2017-09-11  4:08         ` Ming Lei
2017-09-13 18:37           ` Omar Sandoval
2017-09-14  1:56             ` Ming Lei
2017-09-14 14:59               ` Omar Sandoval
2017-09-14 15:18                 ` Omar Sandoval
2017-09-15  1:57                 ` Ming Lei
2017-09-02 15:17 ` [PATCH V4 03/14] blk-mq: introduce blk_mq_dispatch_rq_from_ctx() Ming Lei
2017-09-15  0:04   ` Omar Sandoval
2017-09-15  1:50     ` Ming Lei
2017-09-02 15:17 ` [PATCH V4 04/14] blk-mq-sched: move actual dispatching into one helper Ming Lei
2017-09-19 19:21   ` Omar Sandoval
2017-09-02 15:17 ` [PATCH V4 05/14] blk-mq-sched: improve dispatching from sw queue Ming Lei
2017-09-08 23:54   ` Omar Sandoval
2017-09-10  4:45     ` Ming Lei
2017-09-10 17:38       ` Omar Sandoval
2017-09-11  4:13         ` Ming Lei
2017-09-13 17:32           ` Omar Sandoval
2017-09-19 20:37   ` Jens Axboe
2017-09-20  2:37     ` Ming Lei
2017-09-20 12:20     ` Ming Lei
2017-09-22  2:15       ` Ming Lei
2017-09-02 15:17 ` [PATCH V4 06/14] blk-mq-sched: don't dequeue request until all in ->dispatch are flushed Ming Lei
2017-09-19 19:11   ` Omar Sandoval
2017-09-20  2:55     ` Ming Lei
2017-09-02 15:17 ` [PATCH V4 07/14] blk-mq-sched: introduce blk_mq_sched_queue_depth() Ming Lei
2017-09-02 15:17 ` [PATCH V4 08/14] blk-mq-sched: use q->queue_depth as hint for q->nr_requests Ming Lei
2017-09-02 15:17 ` [PATCH V4 09/14] block: introduce rqhash helpers Ming Lei
2017-09-02 15:17 ` Ming Lei [this message]
2017-09-02 15:17 ` [PATCH V4 11/14] block: add check on elevator for supporting bio merge via hashtable from blk-mq sw queue Ming Lei
2017-09-02 15:17 ` [PATCH V4 12/14] block: introduce .last_merge and .hash to blk_mq_ctx Ming Lei
2017-09-02 15:17 ` [PATCH V4 13/14] blk-mq-sched: refactor blk_mq_sched_try_merge() Ming Lei
2017-09-02 15:17 ` [PATCH V4 14/14] blk-mq: improve bio merge from blk-mq sw queue Ming Lei
2017-09-04  9:12 ` [PATCH V4 00/14] blk-mq-sched: improve SCSI-MQ performance Paolo Valente
2017-09-05  1:39   ` Ming Lei
2017-09-06 15:27     ` Ming Lei
2017-09-19 19:25 ` Omar Sandoval
2017-09-20  3:18   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170902151729.6162-11-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@fb.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=loberman@redhat.com \
    --cc=mgorman@techsingularity.net \
    --cc=paolo.valente@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).