From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
linux-xfs@vger.kernel.org, sandeen@sandeen.net,
Omar Sandoval <osandov@fb.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize
Date: Tue, 5 Sep 2017 16:44:12 +1000 [thread overview]
Message-ID: <20170905064412.GK17782@dastard> (raw)
In-Reply-To: <20170905063139.GA679@infradead.org>
On Mon, Sep 04, 2017 at 11:31:39PM -0700, Christoph Hellwig wrote:
> On Tue, Sep 05, 2017 at 11:14:42AM +0530, Chandan Rajendra wrote:
> > Linux kernel commit 6c6b6f28b3335fd85ec833ee0005d9c9dca6c003 (loop: set
> > physical block size to PAGE_SIZE) now sets PAGE_SIZE as the default
> > physical sector size of loop devices. On ppc64, this causes loop devices
> > to have 64k as the physical sector size.
>
> Eek. We'll need to revert the loop change ASAP!
And, FWIW, making the warning go away if probably a bad idea,
because XFS only supports devices with sector sizes up
to 32k:
#define XFS_MIN_SECTORSIZE_LOG 9 /* i.e. 512 bytes */
#define XFS_MAX_SECTORSIZE_LOG 15 /* i.e. 32768 bytes */
And so it should be warning about devices trying to tell it to use
something larger....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-09-05 6:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170905054442.28615-1-chandan@linux.vnet.ibm.com>
2017-09-05 6:31 ` [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize Christoph Hellwig
2017-09-05 6:42 ` Omar Sandoval
2017-09-05 7:37 ` Chandan Rajendra
2017-09-05 15:00 ` Jens Axboe
2017-09-05 22:06 ` Dave Chinner
2017-09-05 22:18 ` Omar Sandoval
2017-09-05 23:24 ` Dave Chinner
2017-09-06 0:01 ` Omar Sandoval
2017-09-05 6:44 ` Dave Chinner [this message]
2017-09-05 14:17 ` Eric Sandeen
2017-09-05 22:10 ` Dave Chinner
2017-09-05 22:16 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905064412.GK17782@dastard \
--to=david@fromorbit.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=osandov@fb.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox