From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 8 Sep 2017 10:20:40 +0200 From: Christoph Hellwig To: Damien Le Moal Cc: linux-scsi@vger.kernel.org, "Martin K . Petersen" , linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig , Bart Van Assche Subject: Re: [PATCH V2 00/12] scsi-mq support for ZBC disks Message-ID: <20170908082040.GA25719@lst.de> References: <20170907161640.30465-1-damien.lemoal@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170907161640.30465-1-damien.lemoal@wdc.com> List-ID: I'm really worried about how this is tied into the sd driver. >>From a quick look it seems like the only thing you really need in the scheduler that is done through struct scsi_disk is the offset + len -> zone number lookup - I'd much rather expose this from sd upwards and keep the scheduler in the block code. Except for that this looks like a fine approach to me.