From: Ming Lei <ming.lei@redhat.com>
To: "jianchao.wang" <jianchao.w.wang@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-mq: put the driver tag of nxt rq before first one is requeued
Date: Wed, 13 Sep 2017 09:52:27 +0800 [thread overview]
Message-ID: <20170913015221.GB24642@ming.t460p> (raw)
In-Reply-To: <4b7dcb10-9ec5-9a00-8d16-009e83ef7b5b@oracle.com>
On Wed, Sep 13, 2017 at 09:39:44AM +0800, jianchao.wang wrote:
>
>
> On 09/13/2017 09:24 AM, Ming Lei wrote:
> > On Wed, Sep 13, 2017 at 09:01:25AM +0800, jianchao.wang wrote:
> >> Hi ming
> >>
> >> On 09/12/2017 06:23 PM, Ming Lei wrote:
> >>>> @@ -1029,14 +1029,20 @@ bool blk_mq_dispatch_rq_list(struct request_queue *q, struct list_head *list)
> >>>> if (list_empty(list))
> >>>> bd.last = true;
> >>>> else {
> >>>> - struct request *nxt;
> >>>> -
> >>>> nxt = list_first_entry(list, struct request, queuelist);
> >>>> bd.last = !blk_mq_get_driver_tag(nxt, NULL, false);
> >>>> }
> >>>>
> >>>> ret = q->mq_ops->queue_rq(hctx, &bd);
> >>>> if (ret == BLK_STS_RESOURCE) {
> >>>> + /*
> >>>> + * If an I/O scheduler has been configured and we got a
> >>>> + * driver tag for the next request already, free it again.
> >>>> + */
> >>>> + if (!list_empty(list)) {
> >>>> + nxt = list_first_entry(list, struct request, queuelist);
> >>>> + blk_mq_put_driver_tag(nxt);
> >>>> + }
> >>> The following way might be more simple and clean:
> >>>
> >>> if (nxt)
> >>> blk_mq_put_driver_tag(nxt);
> >>>
> >>> meantime 'nxt' need to be cleared inside the 'if (list_empty(list))'
> >>> before .queue_rq().
> >>
> >> I had ever thought about that, but to avoid add extra command in the
> >> fast path, I made the patch above.
> >
> > Got it, so how about changing to the following way simply:
> >
> > if (nxt && !list_empty(list))
> > blk_mq_put_driver_tag(nxt);
> >
> It seems that we even could change it as following:
> if (!list_empty(list))
> blk_mq_put_driver_tag(nxt);
Yeah, that is definitely more clean, :-)
Feel free to add "Reviewed-by: Ming Lei <ming.lei@redhat.com>"
in your next post.
--
Ming
next prev parent reply other threads:[~2017-09-13 1:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 17:14 [PATCH] blk-mq: put the driver tag of nxt rq before first one is requeued Jianchao Wang
2017-09-12 10:23 ` Ming Lei
2017-09-13 1:01 ` jianchao.wang
2017-09-13 1:24 ` Ming Lei
2017-09-13 1:39 ` jianchao.wang
2017-09-13 1:52 ` Ming Lei [this message]
2017-09-13 2:23 ` Jens Axboe
2017-09-13 2:42 ` jianchao.wang
2017-09-13 2:45 ` Jens Axboe
2017-09-13 3:39 ` jianchao.wang
2017-09-13 3:54 ` Jens Axboe
2017-09-13 3:59 ` jianchao.wang
2017-09-13 3:50 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913015221.GB24642@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox