From: Josef Bacik <josef@toxicpanda.com>
To: Dan Melnic <dmm@fb.com>
Cc: josef@toxicpanda.com, axboe@fb.com, linux-block@vger.kernel.org,
Kernel-team@fb.com
Subject: Re: [PATCH V2] block/ndb: add WQ_UNBOUND to the knbd-recv workqueue
Date: Mon, 18 Sep 2017 15:58:23 -0400 [thread overview]
Message-ID: <20170918195822.olbpxndtsgfetgmr@destiny> (raw)
In-Reply-To: <20170918195617.2411456-1-dmm@fb.com>
On Mon, Sep 18, 2017 at 12:56:17PM -0700, Dan Melnic wrote:
> Add WQ_UNBOUND to the knbd-recv workqueue so we're not bound
> to a single CPU that is selected at device creation time.
>
> Signed-off-by: Dan Melnic <dmm@fb.com>
> ---
> drivers/block/nbd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> index 2aa87cb..ac3c5ecc 100644
> --- a/drivers/block/nbd.c
> +++ b/drivers/block/nbd.c
> @@ -2080,7 +2080,9 @@ static int __init nbd_init(void)
> if (nbds_max > 1UL << (MINORBITS - part_shift))
> return -EINVAL;
> recv_workqueue = alloc_workqueue("knbd-recv",
> - WQ_MEM_RECLAIM | WQ_HIGHPRI, 0);
> + WQ_MEM_RECLAIM | WQ_HIGHPRI |
> + WQ_UNBOUND,
> + 0);
This can go on the line above. You can add
Reviewed-by: Josef Bacik <jbacik@fb.com>
once you've made that adjustment. Thanks,
Josef
prev parent reply other threads:[~2017-09-18 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 19:56 [PATCH V2] block/ndb: add WQ_UNBOUND to the knbd-recv workqueue Dan Melnic
2017-09-18 19:58 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918195822.olbpxndtsgfetgmr@destiny \
--to=josef@toxicpanda.com \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=dmm@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox