From: Anish Jhaveri <anish.jhaveri@paviliondata.com>
To: Christoph Hellwig <hch@lst.de>
Cc: sagi@grimberg.me, keith.busch@intel.com, axboe@kernel.dk,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 00/10] nvme multipath support on top of nvme-4.13 branch
Date: Mon, 18 Sep 2017 22:10:37 -0700 [thread overview]
Message-ID: <20170919051036.ttno3memte777ddx@haynes> (raw)
In-Reply-To: <20170915180701.GA8981@lst.de>
On Fri, Sep 15, 2017 at 08:07:01PM +0200, Christoph Hellwig wrote:
> Hi Anish,
>
> I looked over the code a bit, and I'm rather confused by the newly
> added commands. Which controller supports them? Also the NVMe
> working group went down a very different way with the ALUA approch,
> which uses different grouping concepts and doesn't require path
> activations - for Linux we'd really like to stick to only standardized
> multipath implementations.
Hi Christoph,
Thanks for looking over the code. The newly added commands were to
support Asymmetric NVME Namespace Subsystem. Though, I can remove
those commands and make it active-active configuration. I noticed
you have sent out the review with changes adding new structures
and functions which makes it very similar in terms of implementation.
The only reason I proposed given changes, as it doesn't require any
change to kernel.
prev parent reply other threads:[~2017-09-19 5:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 4:20 [PATCH 00/10] nvme multipath support on top of nvme-4.13 branch Anish M Jhaveri
2017-09-13 6:57 ` Hannes Reinecke
2017-09-19 4:40 ` anish.jhaveri
2017-09-15 18:07 ` Christoph Hellwig
2017-09-19 5:10 ` Anish Jhaveri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919051036.ttno3memte777ddx@haynes \
--to=anish.jhaveri@paviliondata.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox