From: Christoph Hellwig <hch@infradead.org>
To: Meng Xu <mengxu.gatech@gmail.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, meng.xu@gatech.edu,
sanidhya@gatech.edu, taesoo@gatech.edu
Subject: Re: [PATCH] scsi: ensure the header peeked does not change in the actual message
Date: Tue, 19 Sep 2017 09:01:02 -0700 [thread overview]
Message-ID: <20170919160102.GA17416@infradead.org> (raw)
In-Reply-To: <1505834638-37142-1-git-send-email-mengxu.gatech@gmail.com>
> diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
> index 7440de4..971044d 100644
> --- a/block/scsi_ioctl.c
> +++ b/block/scsi_ioctl.c
> @@ -466,6 +466,12 @@ int sg_scsi_ioctl(struct request_queue *q, struct gendisk *disk, fmode_t mode,
> if (copy_from_user(req->cmd, sic->data, cmdlen))
> goto error;
>
> + /*
> + * override the request header (opcode) to make sure that it matches
> + * the first fetch from sic->data
> + */
> + *((unsigned int *)req->cmd) = opcode;
> +
> if (in_len && copy_from_user(buffer, sic->data + cmdlen, in_len))
NAK.
Just don't copy the byte twice. E.g. change things to not copy
the first byte again.
next prev parent reply other threads:[~2017-09-19 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 15:23 [PATCH] scsi: ensure the header peeked does not change in the actual message Meng Xu
2017-09-19 16:01 ` Christoph Hellwig [this message]
2017-09-19 16:15 ` Meng Xu
2017-09-19 20:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919160102.GA17416@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=meng.xu@gatech.edu \
--cc=mengxu.gatech@gmail.com \
--cc=sanidhya@gatech.edu \
--cc=taesoo@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).