From: Christoph Hellwig <hch@infradead.org>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: consider merge of segments when merge bio into rq
Date: Wed, 20 Sep 2017 18:29:49 -0700 [thread overview]
Message-ID: <20170921012949.GA29873@infradead.org> (raw)
In-Reply-To: <1505517709-2478-1-git-send-email-jianchao.w.wang@oracle.com>
So the check change here looks good to me.
I don't like like the duplicate code, can you look into sharing
the new segment checks between the two functions and the existing
instance in ll_merge_requests_fn by passing say two struct bio *bio1
and struct bio *bio2 pointer instead of using req->bio and req->biotail?
Also please include the information that you posted in the reply to
the other patch in the description for this one.
next prev parent reply other threads:[~2017-09-21 1:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 23:21 [PATCH] block: consider merge of segments when merge bio into rq Jianchao Wang
2017-09-21 1:29 ` Christoph Hellwig [this message]
2017-09-21 1:34 ` jianchao.wang
2017-09-21 2:46 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921012949.GA29873@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).