From: weiping zhang <zhangweiping@didichuxing.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: <linux-block@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] blk-sysfs: return EINVAL when user modify nr_request less than BLKDEV_MIN_RQ
Date: Fri, 22 Sep 2017 01:12:31 +0800 [thread overview]
Message-ID: <20170921171231.GB2009@localhost.didichuxing.com> (raw)
In-Reply-To: <efeb86f4-2752-975b-a5c9-bd08deb7fd21@kernel.dk>
On Thu, Sep 21, 2017 at 10:38:22AM -0600, Jens Axboe wrote:
> On 09/21/2017 09:17 AM, weiping zhang wrote:
> > Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
> > ---
> > block/blk-sysfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
> > index b8362c0..03a6e19 100644
> > --- a/block/blk-sysfs.c
> > +++ b/block/blk-sysfs.c
> > @@ -75,7 +75,7 @@ queue_requests_store(struct request_queue *q, const char *page, size_t count)
> > return ret;
> >
> > if (nr < BLKDEV_MIN_RQ)
> > - nr = BLKDEV_MIN_RQ;
> > + return -EINVAL;
>
> This is potentially breaking existing scripts.
>
I just want this keep same behavior with the too larger case, If this
may make other side effect, I drop this patch.
Thanks
weiping
prev parent reply other threads:[~2017-09-21 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 15:16 [PATCH v2 0/2] fix wrong value when user modify nr_request by sysfs weiping zhang
2017-09-21 15:17 ` [PATCH v2 1/2] blk-mq: fix nr_requests wrong value when modify it from sysfs weiping zhang
2017-09-21 16:37 ` Jens Axboe
2017-09-21 17:09 ` weiping zhang
2017-09-21 15:17 ` [PATCH v2 2/2] blk-sysfs: return EINVAL when user modify nr_request less than BLKDEV_MIN_RQ weiping zhang
2017-09-21 16:38 ` Jens Axboe
2017-09-21 17:12 ` weiping zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921171231.GB2009@localhost.didichuxing.com \
--to=zhangweiping@didichuxing.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox