From: Bart Van Assche <bart.vanassche@wdc.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
=Oleksandr Natalenko <oleksandr@natalenko.name>,
Bart Van Assche <bart.vanassche@wdc.com>
Subject: [PATCH v3 0/6] Make SCSI device suspend and resume work reliably
Date: Fri, 22 Sep 2017 15:13:59 -0700 [thread overview]
Message-ID: <20170922221405.22091-1-bart.vanassche@wdc.com> (raw)
Hello Jens,
It is known that during the resume following a hibernate sometimes the
system hangs instead of coming up properly. This patch series fixes this
problem. This patch series is an alternative for Ming Lei's "[PATCH V5
0/10] block/scsi: safe SCSI quiescing" patch series. The advantages of
this patch series are:
- Easier to review because no new race conditions are introduced between
queue freezing and blk_cleanup_queue(). As the discussion that followed
Ming's patch series shows the correctness of the new code is hard to
verify.
- No new freeze modes and hence no new freeze mode variables.
These patches have been tested on top of a merge of the block layer
for-next branch and Linus' master tree. Linus' master tree includes
patch "KVM: x86: Fix the NULL pointer parameter in check_cr_write()"
but the block layer for-next branch not yet.
Please consider these changes for kernel v4.15.
Thanks,
Bart.
Changes between v2 and v3:
- Made md kernel threads freezable.
- Changed the approach for quiescing SCSI devices again.
- Addressed Ming's review comments.
Changes compared to v1 of this patch series:
- Changed the approach and rewrote the patch series.
Bart Van Assche (6):
md: Make md resync and reshape threads freezable
block: Convert RQF_PREEMPT into REQ_PREEMPT
block: Add the QUEUE_FLAG_PREEMPT_ONLY request queue flag
scsi: Set QUEUE_FLAG_PREEMPT_ONLY while quiesced
block: Make SCSI device suspend and resume work reliably
scsi-mq: Reduce suspend latency
block/blk-core.c | 46 +++++++++++++++++++++++++++++++++++++++-------
block/blk-mq-debugfs.c | 2 +-
block/blk-mq.c | 4 ++--
block/blk-timeout.c | 2 +-
drivers/ide/ide-atapi.c | 3 +--
drivers/ide/ide-io.c | 2 +-
drivers/ide/ide-pm.c | 4 ++--
drivers/md/md.c | 21 +++++++++++++--------
drivers/scsi/scsi_lib.c | 36 ++++++++++++++++++++++++++----------
fs/block_dev.c | 4 ++--
include/linux/blk_types.h | 6 ++++++
include/linux/blkdev.h | 10 ++++++----
12 files changed, 100 insertions(+), 40 deletions(-)
--
2.14.1
next reply other threads:[~2017-09-22 22:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 22:13 Bart Van Assche [this message]
2017-09-22 22:14 ` [PATCH v3 1/6] md: Make md resync and reshape threads freezable Bart Van Assche
2017-09-25 2:38 ` Ming Lei
2017-09-25 16:22 ` Bart Van Assche
2017-09-25 22:45 ` Ming Lei
2017-09-25 22:48 ` Bart Van Assche
2017-09-22 22:14 ` [PATCH v3 2/6] block: Convert RQF_PREEMPT into REQ_PREEMPT Bart Van Assche
2017-09-22 22:14 ` [PATCH v3 3/6] block: Add the QUEUE_FLAG_PREEMPT_ONLY request queue flag Bart Van Assche
2017-09-22 22:14 ` [PATCH v3 4/6] scsi: Set QUEUE_FLAG_PREEMPT_ONLY while quiesced Bart Van Assche
2017-09-22 22:14 ` [PATCH v3 5/6] block: Make SCSI device suspend and resume work reliably Bart Van Assche
2017-09-25 2:26 ` Ming Lei
2017-09-25 16:20 ` Bart Van Assche
2017-09-25 22:51 ` Ming Lei
2017-09-25 23:06 ` Bart Van Assche
2017-09-22 22:14 ` [PATCH v3 6/6] scsi-mq: Reduce suspend latency Bart Van Assche
2017-09-25 2:28 ` Ming Lei
2017-09-25 2:36 ` [PATCH v3 0/6] Make SCSI device suspend and resume work reliably Ming Lei
2017-09-25 16:17 ` Bart Van Assche
2017-09-25 16:20 ` hch
2017-09-26 9:11 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922221405.22091-1-bart.vanassche@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=oleksandr@natalenko.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox