From: Christoph Hellwig <hch@infradead.org>
To: Benjamin Block <bblock@linux.vnet.ibm.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
Steffen Maier <maier@linux.vnet.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/1] bsg-lib: fix use-after-free under memory-pressure
Date: Mon, 25 Sep 2017 08:53:07 -0700 [thread overview]
Message-ID: <20170925155307.GA27522@infradead.org> (raw)
In-Reply-To: <9040282c25a027344945e9be2c3afc3d90386909.1506016742.git.bblock@linux.vnet.ibm.com>
> if (!q)
> return ERR_PTR(-ENOMEM);
> q->cmd_size = sizeof(struct bsg_job) + dd_job_size;
> - q->init_rq_fn = bsg_init_rq;
> - q->exit_rq_fn = bsg_exit_rq;
> + q->init_rq_fn = bsg_init_job;
> + q->exit_rq_fn = bsg_exit_job;
> + q->initialize_rq_fn = bsg_init_rq;
Please use function names that match the method names, that is keep
the existing names and name the new helper bsg_initialize_rq;
Except for that the patch looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-09-25 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 18:17 [PATCH 1/1] bsg-lib: fix use-after-free under memory-pressure Benjamin Block
2017-09-25 15:53 ` Christoph Hellwig [this message]
2017-09-25 16:54 ` Benjamin Block
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925155307.GA27522@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bblock@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).