From: weiping zhang <zhangweiping@didichuxing.com>
To: <axboe@kernel.dk>, <jthumshirn@suse.de>
Cc: <linux-block@vger.kernel.org>
Subject: [PATCH v3] blkcg: add sanity check for blkcg policy operations
Date: Thu, 12 Oct 2017 14:47:24 +0800 [thread overview]
Message-ID: <20171012064714.GA3069@bogon.didichuxing.com> (raw)
blkcg policy should keep cpd/pd's alloc_fn and free_fn in pairs,
otherwise policy would register fail.
Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
---
block/blk-cgroup.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index e7ec676..6c5f5f3 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -1419,6 +1419,13 @@ int blkcg_policy_register(struct blkcg_policy *pol)
if (i >= BLKCG_MAX_POLS)
goto err_unlock;
+ /* Make sure cpd_alloc_fn and cpd_free_fn in pairs */
+ if (!pol->cpd_alloc_fn ^ !pol->cpd_free_fn)
+ goto err_unlock;
+
+ if (!pol->pd_alloc_fn ^ !pol->pd_free_fn)
+ goto err_unlock;
+
/* register @pol */
pol->plid = i;
blkcg_policy[pol->plid] = pol;
--
2.9.4
next reply other threads:[~2017-10-12 6:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 6:47 weiping zhang [this message]
2017-10-12 7:58 ` [PATCH v3] blkcg: add sanity check for blkcg policy operations Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012064714.GA3069@bogon.didichuxing.com \
--to=zhangweiping@didichuxing.com \
--cc=axboe@kernel.dk \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox