From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Keith Busch <keith.busch@intel.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 5/9] nvme: track subsystems
Date: Wed, 18 Oct 2017 12:12:30 +0200 [thread overview]
Message-ID: <20171018101230.GA14859@lst.de> (raw)
In-Reply-To: <1535c6f9-8ddf-ab30-2bbd-5d9ce626b913@grimberg.me>
>> static void nvme_free_ctrl(struct kref *kref)
>> {
>> struct nvme_ctrl *ctrl = container_of(kref, struct nvme_ctrl, kref);
>> + struct nvme_subsystem *subsys = ctrl->subsys;
>> put_device(ctrl->device);
>> nvme_release_instance(ctrl);
>> ida_destroy(&ctrl->ns_ida);
>> + if (subsys) {
>> + mutex_lock(&subsys->lock);
>> + list_del(&ctrl->subsys_entry);
>> + mutex_unlock(&subsys->lock);
>> + }
>> +
>
> When can this happen? can a controller not have a subsys?
When we fail early enough to not have set up the subsystem yet.
next prev parent reply other threads:[~2017-10-18 10:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 13:40 nvme multipath support V3 Christoph Hellwig
2017-09-25 13:40 ` [PATCH 1/9] block: move REQ_NOWAIT Christoph Hellwig
2017-10-11 11:51 ` Sagi Grimberg
2017-09-25 13:40 ` [PATCH 2/9] block: add REQ_DRV bit Christoph Hellwig
2017-10-11 11:51 ` Sagi Grimberg
2017-09-25 13:40 ` [PATCH 3/9] block: provide a direct_make_request helper Christoph Hellwig
2017-10-11 11:54 ` Sagi Grimberg
2017-09-25 13:40 ` [PATCH 4/9] block: add a blk_steal_bios helper Christoph Hellwig
2017-09-25 13:40 ` [PATCH 5/9] nvme: track subsystems Christoph Hellwig
2017-09-25 16:07 ` Keith Busch
2017-10-11 11:57 ` Sagi Grimberg
2017-10-18 10:12 ` Christoph Hellwig [this message]
2017-10-18 11:16 ` Sagi Grimberg
2017-09-25 13:40 ` [PATCH 6/9] nvme: introduce a nvme_ns_ids structure Christoph Hellwig
2017-09-25 16:08 ` Keith Busch
2017-10-11 11:59 ` Sagi Grimberg
2017-09-25 13:40 ` [PATCH 7/9] nvme: track shared namespaces Christoph Hellwig
2017-09-25 16:11 ` Keith Busch
2017-09-25 16:19 ` Christoph Hellwig
2017-10-11 12:04 ` Sagi Grimberg
2017-10-18 10:15 ` Christoph Hellwig
2017-09-25 13:40 ` [PATCH 8/9] nvme: implement multipath access to nvme subsystems Christoph Hellwig
2017-09-25 13:47 ` Hannes Reinecke
2017-09-25 13:50 ` Christoph Hellwig
2017-09-25 14:05 ` Hannes Reinecke
2017-09-25 14:45 ` Keith Busch
2017-09-25 15:07 ` Christoph Hellwig
2017-09-25 16:18 ` Keith Busch
2017-09-28 15:53 ` Keith Busch
2017-09-29 14:21 ` Tony Yang
2017-10-01 8:07 ` Christoph Hellwig
2017-09-30 19:37 ` Johannes Thumshirn
2017-10-01 8:07 ` Christoph Hellwig
2017-10-02 6:19 ` Hannes Reinecke
2017-10-11 12:24 ` Sagi Grimberg
2017-09-25 13:40 ` [PATCH 9/9] nvme: also expose the namespace identification sysfs files for mpath nodes Christoph Hellwig
2017-09-25 16:19 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018101230.GA14859@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).