linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@fb.com>,
	linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Cc: Omar Sandoval <osandov@fb.com>,
	Bart Van Assche <bart.vanassche@sandisk.com>,
	Roman Pen <roman.penyaev@profitbricks.com>,
	Hannes Reinecke <hare@suse.com>, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V2 0/2] block: remove unnecessary RESTART
Date: Fri, 27 Oct 2017 12:43:28 +0800	[thread overview]
Message-ID: <20171027044330.11921-1-ming.lei@redhat.com> (raw)

Hi Jens,

The 1st patch removes the RESTART for TAG-SHARED because SCSI handles it
by itself, and not necessary to waste CPU to do the expensive RESTART.
And Roman Pen reported that this RESTART cuts half of IOPS in his case.

The 2nd patch removes the RESTART when .get_budget returns BLK_STS_RESOURCE,
and this RESTART is handled by SCSI's RESTART(scsi_end_request()) too.


Ming Lei (2):
  blk-mq: don't handle TAG_SHARED in restart
  blk-mq: don't restart queue when .get_budget returns BLK_STS_RESOURCE

 block/blk-mq-sched.c | 123 ++++-----------------------------------------
 block/blk-mq-sched.h |   2 +-
 block/blk-mq.c       |   8 +---
 3 files changed, 27 insertions(+), 106 deletions(-)

-- 
2.9.5

             reply	other threads:[~2017-10-27  4:43 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27  4:43 Ming Lei [this message]
2017-10-27  4:43 ` [PATCH V2 1/2] blk-mq: don't handle TAG_SHARED in restart Ming Lei
2017-10-27  4:43 ` [PATCH V2 2/2] blk-mq: don't restart queue when .get_budget returns BLK_STS_RESOURCE Ming Lei
2017-10-27  4:53 ` [PATCH V2 0/2] block: remove unnecessary RESTART Bart Van Assche
2017-10-27  5:38   ` Ming Lei
2017-10-27 17:55     ` Roman Penyaev
2017-10-28 15:47       ` Ming Lei
2017-10-30 20:33       ` Bart Van Assche
2017-11-01 16:55         ` Roman Penyaev
2017-10-30 20:24     ` Bart Van Assche
2017-10-31  1:47       ` Ming Lei
2017-11-01  3:54         ` Bart Van Assche
2017-11-01  4:08           ` Ming Lei
2017-11-01 16:47             ` Bart Van Assche
2017-11-01 16:59               ` Ming Lei
2017-11-01 17:09                 ` Bart Van Assche
2017-11-01 17:22                   ` Ming Lei
2017-10-31 20:29 ` Jens Axboe
2017-11-01  1:46   ` Ming Lei
2017-11-01  1:53     ` Jens Axboe
2017-11-01  2:03       ` Ming Lei
2017-11-01 14:21         ` Jens Axboe
2017-11-02 15:57           ` Bart Van Assche
2017-11-02 23:38             ` Ming Lei
2017-11-02 23:43               ` Bart Van Assche
2017-11-02 23:48                 ` Ming Lei
2017-11-02 23:54                   ` Bart Van Assche
2017-11-03  0:15                     ` Ming Lei
2017-11-03  0:48                       ` Bart Van Assche
2017-11-03  1:16                         ` Laurence Oberman
2017-11-03  2:12                           ` Ming Lei
2017-11-03  2:42                             ` Bart Van Assche
2017-11-03  3:50                               ` Ming Lei
2017-11-03 15:23                                 ` Bart Van Assche
2017-11-03 15:47                                   ` Ming Lei
2017-11-03 15:50                                     ` Bart Van Assche
2017-11-03 16:13                                       ` Laurence Oberman
2017-11-03 16:47                                         ` Ming Lei
2017-11-03 17:13                                           ` Laurence Oberman
2017-11-04  2:11                                           ` Ming Lei
2017-11-03 15:18                               ` Ming Lei
2017-11-03 15:43                                 ` Bart Van Assche
2017-11-03 15:47                                 ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171027044330.11921-1-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@fb.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=hare@suse.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=roman.penyaev@profitbricks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).