From: Christoph Hellwig <hch@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [PATCH] bio: have bio_kmap_irq return the size of mapped data (fwd)
Date: Wed, 8 Nov 2017 01:47:30 -0800 [thread overview]
Message-ID: <20171108094730.GA7074@infradead.org> (raw)
In-Reply-To: <alpine.LRH.2.02.1711071641090.1339@file01.intranet.prod.int.rdu2.redhat.com>
On Tue, Nov 07, 2017 at 04:45:17PM -0500, Mikulas Patocka wrote:
> Hi
>
> I need the function bio_kmap_irq in the driver that I am developing, but
> it doesn't return the size of the mapped data. I've made this patch to fix
> it.
To be honest I think we should just remove bio_kmap_irq. It is currently
unused and assumes there is only a single bvec to map.
I think you're much better off using a proper bvec iterator in your
caller and then call bvec_kmap_irq/bvec_kunmap_irq manually.
next prev parent reply other threads:[~2017-11-08 9:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 21:45 [PATCH] bio: have bio_kmap_irq return the size of mapped data (fwd) Mikulas Patocka
2017-11-08 9:47 ` Christoph Hellwig [this message]
2017-11-08 12:38 ` Mikulas Patocka
2017-11-08 15:05 ` Christoph Hellwig
2017-11-08 15:20 ` Jens Axboe
2017-11-08 15:34 ` [dm-devel] " Christoph Hellwig
2017-11-08 15:36 ` Jens Axboe
2017-11-08 18:03 ` Christoph Hellwig
2017-11-08 18:08 ` Jens Axboe
2017-11-08 18:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108094730.GA7074@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).