From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
Mikulas Patocka <mpatocka@redhat.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH] bio: have bio_kmap_irq return the size of mapped data (fwd)
Date: Wed, 8 Nov 2017 10:03:58 -0800 [thread overview]
Message-ID: <20171108180358.GA6724@infradead.org> (raw)
In-Reply-To: <aabd8f47-3b9f-ffb5-474e-ab0841806a39@kernel.dk>
On Wed, Nov 08, 2017 at 08:36:25AM -0700, Jens Axboe wrote:
> On 11/08/2017 08:34 AM, Christoph Hellwig wrote:
> > On Wed, Nov 08, 2017 at 08:20:58AM -0700, Jens Axboe wrote:
> >> On top of that, there are no users of it at all...
> >
> > But Mikulas wants to add one :)
>
> I know...
>
> > Note that __bio_kmap_atomic has the same issues, only has a single
> > users either and would be cleaner if opencoded there as it already
> > has the current bvec. See patch below.
>
> Kill them all with fire. The open coded version is much clearer.
Feel free to throw the patch in under either your or my name.
next prev parent reply other threads:[~2017-11-08 18:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 21:45 [PATCH] bio: have bio_kmap_irq return the size of mapped data (fwd) Mikulas Patocka
2017-11-08 9:47 ` Christoph Hellwig
2017-11-08 12:38 ` Mikulas Patocka
2017-11-08 15:05 ` Christoph Hellwig
2017-11-08 15:20 ` Jens Axboe
2017-11-08 15:34 ` [dm-devel] " Christoph Hellwig
2017-11-08 15:36 ` Jens Axboe
2017-11-08 18:03 ` Christoph Hellwig [this message]
2017-11-08 18:08 ` Jens Axboe
2017-11-08 18:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108180358.GA6724@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).