From: "hch@lst.de" <hch@lst.de>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"mlyle@lyle.org" <mlyle@lyle.org>, "hch@lst.de" <hch@lst.de>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH] bio: ensure __bio_clone_fast copies bi_partno
Date: Fri, 17 Nov 2017 18:18:04 +0100 [thread overview]
Message-ID: <20171117171804.GA27106@lst.de> (raw)
In-Reply-To: <1510937438.2846.16.camel@wdc.com>
On Fri, Nov 17, 2017 at 04:50:39PM +0000, Bart Van Assche wrote:
>
> How about the following class of assignments in drivers/md/raid1.c:
>
> mbio->bi_disk = (void *)conf->mirrors[i].rdev;
>
> Should these assignments perhaps be followed by a mbio->bi_partno assignment?
No. They assign a struct md_rdev to the bi_disk pointer, abusing it
for internal storage. They should not assign mbio->bi_partno.
Instead we should figure out a way to get rid of this.
>
> How about the following class of assignments in the NVMe code:
>
> bio->bi_disk = disk;
>
> Should these assignments perhaps be followed by a bio->bi_partno assignment?
No, the multipath code always works on whole namespaces, not partitions.
next prev parent reply other threads:[~2017-11-17 17:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 7:47 [PATCH] bio: ensure __bio_clone_fast copies bi_partno Michael Lyle
2017-11-17 11:04 ` Coly Li
2017-11-17 11:34 ` Ming Lei
2017-11-17 15:08 ` Christoph Hellwig
2017-11-17 15:27 ` Jens Axboe
2017-11-17 16:50 ` Bart Van Assche
2017-11-17 17:02 ` Michael Lyle
2017-11-17 17:18 ` hch [this message]
2017-11-17 20:25 ` Campbell Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117171804.GA27106@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mlyle@lyle.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).