public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: fstests@vger.kernel.org, Omar Sandoval <osandov@osandov.com>,
	linux-block@vger.kernel.org
Subject: Re: [PATCH] generic/473: test return EBUSY from BLKRRPART for mounted whole-dev
Date: Mon, 4 Dec 2017 17:25:58 +0800	[thread overview]
Message-ID: <20171204092558.GH2749@eguan.usersys.redhat.com> (raw)
In-Reply-To: <5A251225.7080905@cn.fujitsu.com>

On Mon, Dec 04, 2017 at 05:15:17PM +0800, Xiao Yang wrote:
> On 2017/12/04 16:29, Eryu Guan wrote:
> > On Wed, Nov 29, 2017 at 08:02:26PM +0800, Xiao Yang wrote:
> > > If the entire block device is formatted with a filesystem and
> > > mounted, running "blockdev --rereadpt" should fail and return
> > > EBUSY instead of pass.
> > > 
> > > Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
> > As we have blktests[1] now, I think this may fit in blktests better?
> Hi Eryu,
> 
> Do you think test cases which use scsi_debug module should be moved into
> blktests?
> (e.g. generic/108, generic/349, generic/350, generic/351)

I don't think they need to be moved to blktests. Most other tests that
take use of scsi_debug are for filesystem testing, e.g. generic/108.
generic/349 generic/35[01] are a bit special, they were there before
blktests was announced available, so they're in a special blockdev group
and not in the auto group. If Omar agrees, I think they can be ported to
blktests.

Thanks,
Eryu

  reply	other threads:[~2017-12-04  9:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1511956946-16667-1-git-send-email-yangx.jy@cn.fujitsu.com>
2017-12-04  8:29 ` [PATCH] generic/473: test return EBUSY from BLKRRPART for mounted whole-dev Eryu Guan
2017-12-04  9:15   ` Xiao Yang
2017-12-04  9:25     ` Eryu Guan [this message]
2017-12-04  9:48       ` Xiao Yang
2017-12-04 18:29         ` Omar Sandoval
2017-12-19 10:30           ` [PATCH blktests] block/013: Add test for BLKRRPART ioctl xiao yang
2017-12-19 10:47             ` Johannes Thumshirn
2017-12-19 19:42               ` Omar Sandoval
2017-12-20  8:03                 ` Johannes Thumshirn
2017-12-19 23:42             ` Omar Sandoval
2017-12-19 10:45           ` [PATCH] generic/473: test return EBUSY from BLKRRPART for mounted whole-dev Xiao Yang
2017-12-19 10:53             ` Johannes Thumshirn
2017-12-19 10:59               ` Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204092558.GH2749@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@osandov.com \
    --cc=yangx.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox