From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f47.google.com ([74.125.83.47]:46641 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854AbdLDS34 (ORCPT ); Mon, 4 Dec 2017 13:29:56 -0500 Received: by mail-pg0-f47.google.com with SMTP id b11so8773235pgu.13 for ; Mon, 04 Dec 2017 10:29:56 -0800 (PST) Date: Mon, 4 Dec 2017 10:29:53 -0800 From: Omar Sandoval To: Xiao Yang Cc: Eryu Guan , fstests@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH] generic/473: test return EBUSY from BLKRRPART for mounted whole-dev Message-ID: <20171204182953.GA16308@vader.DHCP.thefacebook.com> References: <1511956946-16667-1-git-send-email-yangx.jy@cn.fujitsu.com> <20171204082923.GF2749@eguan.usersys.redhat.com> <5A251225.7080905@cn.fujitsu.com> <20171204092558.GH2749@eguan.usersys.redhat.com> <5A2519F4.5040102@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <5A2519F4.5040102@cn.fujitsu.com> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Mon, Dec 04, 2017 at 05:48:36PM +0800, Xiao Yang wrote: > On 2017/12/04 17:25, Eryu Guan wrote: > > On Mon, Dec 04, 2017 at 05:15:17PM +0800, Xiao Yang wrote: > > > On 2017/12/04 16:29, Eryu Guan wrote: > > > > On Wed, Nov 29, 2017 at 08:02:26PM +0800, Xiao Yang wrote: > > > > > If the entire block device is formatted with a filesystem and > > > > > mounted, running "blockdev --rereadpt" should fail and return > > > > > EBUSY instead of pass. > > > > > > > > > > Signed-off-by: Xiao Yang > > > > As we have blktests[1] now, I think this may fit in blktests better? > > > Hi Eryu, > > > > > > Do you think test cases which use scsi_debug module should be moved into > > > blktests? > > > (e.g. generic/108, generic/349, generic/350, generic/351) > > I don't think they need to be moved to blktests. Most other tests that > > take use of scsi_debug are for filesystem testing, e.g. generic/108. > > generic/349 generic/35[01] are a bit special, they were there before > > blktests was announced available, so they're in a special blockdev group > > and not in the auto group. If Omar agrees, I think they can be ported to > > blktests. > Hi Eryu, > > Thanks for your explanation, and i will try to send it to blktests. > > Thanks, > Xiao Yang I agree, the three tests Eryu mentioned and this new test would be a good fit for blktests. Let me know if you need any help porting, things are a little different from xfstests.