From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/2] scsi-mq: Only show the CDB if available
Date: Tue, 5 Dec 2017 13:00:09 +0800 [thread overview]
Message-ID: <20171205050008.GA9989@ming.t460p> (raw)
In-Reply-To: <1512439190.2739.0.camel@wdc.com>
On Tue, Dec 05, 2017 at 01:59:51AM +0000, Bart Van Assche wrote:
> On Tue, 2017-12-05 at 09:15 +0800, Ming Lei wrote:
> > On Mon, Dec 04, 2017 at 04:38:08PM -0800, Bart Van Assche wrote:
> > > Since the next patch will make it possible that scsi_show_rq() gets
> > > called before the CDB pointer is changed into a non-NULL value,
> > > only show the CDB if the CDB pointer is not NULL. Additionally,
> > > show the request timeout and SCSI command flags. This patch also
> > > fixes a bug that was reported by Ming Lei. See also Ming Lei,
> > > scsi_debugfs: fix crash in scsi_show_rq(), linux-scsi, 7 November
> > > 2017 (https://marc.info/?l=linux-block&m=151006655317188).
> >
> > Please cook a patch for fixing the crash issue only, since we need
> > to backport the fix to stable kernel.
>
> The code that is touched by this patch is only used for kernel debugging.
> I will do this if others agree with your opinion.
No, do not mix two different things in one patch, especially the fix part
need to be backported to stable.
The fix part should aim at V4.15, and the other part can be a V4.16
stuff.
--
Ming
next prev parent reply other threads:[~2017-12-05 5:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 0:38 [PATCH 0/2] Show commands stuck in a timeout handler in debugfs Bart Van Assche
2017-12-05 0:38 ` [PATCH 1/2] scsi-mq: Only show the CDB if available Bart Van Assche
2017-12-05 1:15 ` Ming Lei
2017-12-05 1:59 ` Bart Van Assche
2017-12-05 5:00 ` Ming Lei [this message]
2017-12-05 16:22 ` Bart Van Assche
2017-12-05 16:38 ` Ming Lei
2017-12-05 16:43 ` James Bottomley
2017-12-06 1:16 ` Ming Lei
2017-12-05 17:51 ` Bart Van Assche
2017-12-05 3:42 ` Martin K. Petersen
2017-12-05 4:00 ` Ming Lei
2017-12-05 0:38 ` [PATCH 2/2] blk-mq-debugfs: Also show requests that have not yet been started Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205050008.GA9989@ming.t460p \
--to=ming.lei@redhat.com \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).