From: Omar Sandoval <osandov@osandov.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: xiao yang <yangx.jy@cn.fujitsu.com>,
eguan@redhat.com, fstests@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH blktests] block/013: Add test for BLKRRPART ioctl
Date: Tue, 19 Dec 2017 11:42:28 -0800 [thread overview]
Message-ID: <20171219194228.GB22017@vader.DHCP.thefacebook.com> (raw)
In-Reply-To: <mqd8tdzataq.fsf@linux-x5ow.site>
On Tue, Dec 19, 2017 at 11:47:09AM +0100, Johannes Thumshirn wrote:
> xiao yang <yangx.jy@cn.fujitsu.com> writes:
>
> > +requires() {
> > + _have_program mkfs.ext3
> > +}
> [...]
> > + # Format
> > + mkfs.ext3 -F "$TEST_DEV" >> "$FULL" 2>&1
>
> What's the reason to limit the test case to ext3 only? Can you switch it
> to the generic 'mkfs' command? IIRC we require 'util-linux' to be
> present for blktests but mkfs.ext3 is (at least in SUSE based distros)
> in the e2fsprogs package.
I'm fine with only testing one specific filesystem, since we're really
testing generic functionality and not any filesystem code. And according
to the manpage, bare mkfs is deprecated. I'm fine with requiring
e2fsprogs for this test, and xiao yang added the _have_program there for
it.
> apart from that:
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
next prev parent reply other threads:[~2017-12-19 19:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1511956946-16667-1-git-send-email-yangx.jy@cn.fujitsu.com>
2017-12-04 8:29 ` [PATCH] generic/473: test return EBUSY from BLKRRPART for mounted whole-dev Eryu Guan
2017-12-04 9:15 ` Xiao Yang
2017-12-04 9:25 ` Eryu Guan
2017-12-04 9:48 ` Xiao Yang
2017-12-04 18:29 ` Omar Sandoval
2017-12-19 10:30 ` [PATCH blktests] block/013: Add test for BLKRRPART ioctl xiao yang
2017-12-19 10:47 ` Johannes Thumshirn
2017-12-19 19:42 ` Omar Sandoval [this message]
2017-12-20 8:03 ` Johannes Thumshirn
2017-12-19 23:42 ` Omar Sandoval
2017-12-19 10:45 ` [PATCH] generic/473: test return EBUSY from BLKRRPART for mounted whole-dev Xiao Yang
2017-12-19 10:53 ` Johannes Thumshirn
2017-12-19 10:59 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219194228.GB22017@vader.DHCP.thefacebook.com \
--to=osandov@osandov.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox