From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 00/10] block: cleanup on direct access to bvec table(prepare for multipage bvec)
Date: Sat, 6 Jan 2018 09:21:31 -0700 [thread overview]
Message-ID: <20180106162130.GB6343@kernel.dk> (raw)
In-Reply-To: <20180106091800.GB13472@ming.t460p>
On Sat, Jan 06 2018, Ming Lei wrote:
> On Fri, Jan 05, 2018 at 12:02:10PM -0700, Jens Axboe wrote:
> > On 12/8/17 6:13 AM, Ming Lei wrote:
> > > Hi,
> > >
> > > This patchse cleans up most of direct access to bvec table in tree, and
> > > these patches are the follow-up of patch1 ~ 16 in the patchset of 'block:
> > > support multipage bvec(V3)'[1].
> > >
> > > Changes against [1]:
> > > 1) split the cleanup patches from [1]
> > > 2) address comments from Christoph:
> > > - introduce bio helpers for dealing with the cleanup
> > > - move bio_alloc_pages() to bcache
> > >
> > >
> > > [1] https://marc.info/?t=150218197600001&r=1&w=2
> >
> > Looks like good cleanups to me. I will apply this for 4.16, thanks.
>
> Hi Jens,
>
> Sorry for forgetting to update in this thread, the latest cleanup patchset
> has been included into the following patchset of '[PATCH V4 00/45] block: support
> multipage bvec' as patch 1 ~ 17:
>
> https://marc.info/?t=151359981400006&r=1&w=2
>
> If possible, please revert this 10 patches in your block-tree, and apply
> the whole patchset of '[PATCH V4 00/45] block: support multipage bvec'
> on the above link, and the V4 is much more clean than before.
OK, we can do that, even if I generally dislike doing it. I applied the
first part of the series, I haven't had time to review the latter part,
and others haven't either. So timing isn't great for 4.16.
--
Jens Axboe
prev parent reply other threads:[~2018-01-06 16:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 13:13 [PATCH 00/10] block: cleanup on direct access to bvec table(prepare for multipage bvec) Ming Lei
2017-12-08 13:14 ` [PATCH 01/10] block: introduce bio helpers for converting to multipage bvec Ming Lei
2017-12-08 13:14 ` [PATCH 02/10] block: conver to bio_first_bvec() & bio_first_page() Ming Lei
2017-12-08 13:14 ` [PATCH 03/10] fs: convert to bio_last_bvec() Ming Lei
2017-12-08 13:14 ` [PATCH 04/10] block: bounce: avoid direct access to bvec table Ming Lei
2017-12-08 13:14 ` [PATCH 05/10] block: bounce: don't access bio->bi_io_vec in copy_to_high_bio_irq Ming Lei
2017-12-08 13:14 ` [PATCH 06/10] dm: limit the max bio size as BIO_MAX_PAGES * PAGE_SIZE Ming Lei
2017-12-08 13:14 ` [PATCH 07/10] bcache: comment on direct access to bvec table Ming Lei
2017-12-08 13:14 ` [PATCH 08/10] block: move bio_alloc_pages() to bcache Ming Lei
2018-01-08 18:05 ` Michael Lyle
2018-01-09 1:21 ` Ming Lei
2017-12-08 13:14 ` [PATCH 09/10] btrfs: avoid access to .bi_vcnt directly Ming Lei
2017-12-08 13:14 ` [PATCH 10/10] btrfs: avoid to access bvec table directly for a cloned bio Ming Lei
2017-12-12 7:57 ` [PATCH 00/10] block: cleanup on direct access to bvec table(prepare for multipage bvec) Christoph Hellwig
2017-12-12 9:18 ` Ming Lei
2017-12-13 17:55 ` Ming Lei
2018-01-05 19:02 ` Jens Axboe
2018-01-06 9:18 ` Ming Lei
2018-01-06 16:21 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180106162130.GB6343@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).