From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <keith.busch@intel.com>
Cc: Linux Block <linux-block@vger.kernel.org>,
Linux NVMe <linux-nvme@lists.infradead.org>,
Device Mapper <dm-devel@redhat.com>,
Christoph Hellwig <hch@lst.de>, Mike Snitzer <snitzer@redhat.com>,
Jens Axboe <axboe@kernel.dk>,
Bart VanAssche <bart.vanassche@wdc.com>,
James Smart <james.smart@broadcom.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.com>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 3/5] block: Provide blk_status_t decoding for retryable errors
Date: Mon, 8 Jan 2018 10:58:01 +0100 [thread overview]
Message-ID: <20180108095801.GE4673@lst.de> (raw)
In-Reply-To: <20180104224623.8944-4-keith.busch@intel.com>
> +static inline bool blk_retryable(blk_status_t error)
The naming isn't really useful - it is about the fact that it's
worth retrying on another path. So please chose a better name,
and add a kerneldoc comment describing it.
next prev parent reply other threads:[~2018-01-08 9:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 22:46 [PATCH 0/5] Failover criteria unification Keith Busch
2018-01-04 22:46 ` [PATCH 1/5] nvme: Add more command status translation Keith Busch
2018-01-04 23:41 ` Mike Snitzer
2018-01-08 8:39 ` Hannes Reinecke
2018-01-08 9:55 ` Christoph Hellwig
2018-01-08 10:09 ` Hannes Reinecke
2018-01-08 10:19 ` Christoph Hellwig
2018-01-08 15:29 ` Mike Snitzer
2018-01-08 15:34 ` Christoph Hellwig
2018-01-08 16:12 ` Keith Busch
2018-01-04 22:46 ` [PATCH 2/5] nvme/multipath: Consult blk_status_t for failover Keith Busch
2018-01-04 23:42 ` Mike Snitzer
2018-01-08 8:57 ` Hannes Reinecke
2018-01-08 9:57 ` Christoph Hellwig
2018-01-09 17:38 ` Keith Busch
2018-01-09 17:40 ` Christoph Hellwig
2018-01-04 22:46 ` [PATCH 3/5] block: Provide blk_status_t decoding for retryable errors Keith Busch
2018-01-04 23:43 ` Mike Snitzer
2018-01-08 8:58 ` Hannes Reinecke
2018-01-08 9:58 ` Christoph Hellwig [this message]
2018-01-04 22:46 ` [PATCH 4/5] nvme/multipath: Use blk_retryable Keith Busch
2018-01-04 23:44 ` Mike Snitzer
2018-01-08 8:58 ` Hannes Reinecke
2018-01-04 22:46 ` [PATCH 5/5] dm mpath: " Keith Busch
2018-01-04 23:45 ` Mike Snitzer
2018-01-08 8:59 ` Hannes Reinecke
2018-01-04 23:36 ` [PATCH 0/5] Failover criteria unification Mike Snitzer
2018-01-04 23:47 ` Keith Busch
2018-01-05 0:07 ` Mike Snitzer
2018-01-08 9:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108095801.GE4673@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.com \
--cc=james.smart@broadcom.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).