From: Christoph Hellwig <hch@infradead.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>,
hch@infradead.org
Subject: Re: [PATCH v2] block: silently forbid sending any ioctl to a partition
Date: Wed, 10 Jan 2018 08:54:33 -0800 [thread overview]
Message-ID: <20180110165433.GA3084@infradead.org> (raw)
In-Reply-To: <20180110155452.26563-1-pbonzini@redhat.com>
On Wed, Jan 10, 2018 at 04:54:52PM +0100, Paolo Bonzini wrote:
> After the first few months, the message has not led to many bug reports.
> It's been almost five years now, and in practice the main source of
> it seems to be MTIOCGET that someone is using to detect tape devices.
> While we could whitelist it just like CDROM_GET_CAPABILITY, this patch
> just removes the message altogether.
>
> The patch also removes the "safe but not very useful" ioctl whitelist,
> as suggested by Christoph. I doubt anything is using most of those
> ioctls _in general_, let alone on a partition.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Nice, thanks!
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-01-10 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 15:54 [PATCH v2] block: silently forbid sending any ioctl to a partition Paolo Bonzini
2018-01-10 16:54 ` Christoph Hellwig [this message]
2018-01-10 19:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110165433.GA3084@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).