From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ilya Dryomov <idryomov@gmail.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>, Tejun Heo <tj@kernel.org>,
David Disseldorp <ddiss@suse.de>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v2 1/2] block: fail op_is_write() requests to read-only partitions
Date: Wed, 10 Jan 2018 08:55:28 -0800 [thread overview]
Message-ID: <20180110165528.GB3084@infradead.org> (raw)
In-Reply-To: <854c55f9-280b-de02-0be4-6ee8534802c8@kernel.dk>
On Wed, Jan 10, 2018 at 09:34:02AM -0700, Jens Axboe wrote:
> It's yet another check that adds part lookup and rcu lock/unlock in that
> path. Can we combine some of them? Make this part of the remap? This
> overhead impacts every IO, let's not bloat it more than absolutely
> necessary.
Yes, we should be able to integrate this with the partition remap.
next prev parent reply other threads:[~2018-01-10 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 16:18 [PATCH v2 0/2] block: enforce ioctl(BLKROSET) and set_disk_ro() Ilya Dryomov
2018-01-10 16:18 ` [PATCH v2 1/2] block: fail op_is_write() requests to read-only partitions Ilya Dryomov
2018-01-10 16:34 ` Jens Axboe
2018-01-10 16:49 ` Ilya Dryomov
2018-01-10 16:55 ` Christoph Hellwig [this message]
2018-01-10 16:18 ` [PATCH v2 2/2] block: add bdev_read_only() checks to common helpers Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110165528.GB3084@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=ddiss@suse.de \
--cc=idryomov@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).