From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@infradead.org>,
"jianchao . wang" <jianchao.w.wang@oracle.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Stefan Haberland <sth@linux.vnet.ibm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/2] blk-mq: convert WARN_ON in __blk_mq_run_hw_queue to printk
Date: Thu, 18 Jan 2018 00:17:32 +0800 [thread overview]
Message-ID: <20180117161731.GC21896@ming.t460p> (raw)
In-Reply-To: <39203c80-e718-3aa6-6b21-05a6bf0ad9b0@kernel.dk>
On Wed, Jan 17, 2018 at 08:46:40AM -0700, Jens Axboe wrote:
> On 1/17/18 5:34 AM, Ming Lei wrote:
> > We know this WARN_ON is harmless and the stack trace isn't useful too,
> > so convert it to printk(), and avoid to confuse people.
>
> I disagree, it is useful to know the exact path it happened from,
> in case it's a valid warning. It could be an inline run and
inline run is only possible in theory, since the window is too
small.
> we screwed up the logic, or it could be from a workqueue and
> the reason would be entirely different.
OK, if you don't agree, I will just add the comment on the races
we found.
--
Ming
prev parent reply other threads:[~2018-01-17 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 12:34 [PATCH 0/2] blk-mq: two patches related with CPU hotplug Ming Lei
2018-01-17 12:34 ` [PATCH 1/2] blk-mq: make sure hctx->next_cpu is set correctly Ming Lei
2018-01-17 15:45 ` Jens Axboe
2018-01-17 16:14 ` Ming Lei
2018-01-17 12:34 ` [PATCH 2/2] blk-mq: convert WARN_ON in __blk_mq_run_hw_queue to printk Ming Lei
2018-01-17 15:46 ` Jens Axboe
2018-01-17 16:05 ` Christian Borntraeger
2018-01-17 16:07 ` Jens Axboe
2018-01-17 16:17 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117161731.GC21896@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=borntraeger@de.ibm.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=sth@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox