Re: [PATCH V2 2/8] blk-mq: introduce BLK_MQ_F_GLOBAL_TAGS

Ming Lei
2018-02-07T00:44:55Z

On Tue, Feb 06, 2018 at 12:33:36PM -0800, Omar Sandoval wrote:
> On Mon, Feb 05, 2018 at 11:20:29PM +0800, Ming Lei wrote:
......
> >
> > + /* need to restart all hw queues for global tags */
> > + if (hctx->flags & BLK_MQ_F_GLOBAL_TAGS) {
> > + struct blk_mq_hw_ctx *hctx2;
> > + int i;
> > +
> > + queue_for_each_hw_ctx(hctx->queue, hctx2, i)
> > + if (blk_mq_run_hw_queue(hctx2, true))
> > + return true;
>
> Is it intentional that we stop after the first hw queue does work? That
> seems fine but it's a little confusing because the comment claims we
> restart everything.

Good catch, will update comment in V3.

Thanks,
Ming